-
-
Notifications
You must be signed in to change notification settings - Fork 1
fix(quality): remove unused variables and exclude web from tests #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
protheeuz
commented
Jan 30, 2026
- Remove unused _minFrequency field from MemoryCache
- Remove unused normalizedSql variable from QueryOptimizer
- Update melos test commands to ignore web package (no tests)
- Fix flutter analyze warnings for code quality compliance
- Remove unused _minFrequency field from MemoryCache - Remove unused normalizedSql variable from QueryOptimizer - Update melos test commands to ignore web package (no tests) - Fix flutter analyze warnings for code quality compliance
Summary of ChangesHello @protheeuz, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on enhancing code quality and optimizing the testing process. It removes several unused variables across different classes, which streamlines the codebase and adheres to best practices. Additionally, the testing configuration has been refined to exclude web-specific packages from test runs, improving efficiency and relevance of the test suite. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request provides several quality improvements by removing unused variables in MemoryCache and QueryOptimizer, which simplifies the code and removes dead code. It also updates the Melos test configuration to exclude the web package, which currently has no tests, streamlining the CI process. The changes are correct and well-contained, improving overall code quality and build configuration. I have no specific comments as the changes are solid.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
- Add platform-specific melos installation steps - Use PowerShell for Windows PATH configuration - Unix systems (Linux/macOS) use bash PATH configuration - Fix 'melos: command not found' error on Windows runners
- Windows PATH update in PowerShell not available in bash shell - Use 'flutter pub global run melos' for Windows bootstrap - Add separate bootstrap steps for Unix and Windows - Add release workflow and documentation Changes: - Split bootstrap step by platform - Add RELEASE_PROCESS.md guide - Add automated release workflow
- Remove RELEASE_PROCESS.md from repository - Add to .gitignore for local reference only
- Add --concurrency=1 to melos test commands - Prevents multiple flutter commands from running simultaneously - Fixes 'Waiting for another flutter command to release the startup lock' errors - Update both workflow and melos scripts