Fix loading as browserified in AMD style#9
Open
inetfuture wants to merge 1 commit intomathiasbynens:masterfrom
Open
Fix loading as browserified in AMD style#9inetfuture wants to merge 1 commit intomathiasbynens:masterfrom
inetfuture wants to merge 1 commit intomathiasbynens:masterfrom
Conversation
Author
|
@mathiasbynens please look into this |
|
Thank you @inetfuture ,I have the same problem,I think your patch works for me |
mathiasbynens
force-pushed
the
master
branch
4 times, most recently
from
4eff386 to
d4de352
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I use this library with browserify, then generate the dist for others to use. One of them tried to load it with requirejs with shim config, it failed, because this library take over the whole module.
I'm not sure if my change is appropriate, just tell me if you think it's not, thanks.