Develop #882
Develop #882
Conversation
brespect
left a comment
brespect
left a comment
There was a problem hiding this comment.
Hello, first of all, you should deploy your DEMO Link.
Regarding Redux - if the task requires using it, then you need to do exactly that, imagining that this is, for example, a requirement of a real customer.
Regarding the questions about placement and indentation, review the design in detail and try to implement something that is, as it were, but not a perfect pixel, if you have specific questions in the sections, it is better to contact fe_chat, it is much easier this way. It is also very important that all tests pass before sending it to the mentor for review
|
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
- add favicon and change title
- your page looks broken because of path to assets.
To fix this use relative path instead of absolute. (should start with .)
if you need some help - feel free to ask in fe_chat 💬
| useEffect(() => { | ||
| const hasParams = searchParams.toString().length > 0; | ||
|
|
||
| if (!hasParams) { | ||
| const defaultParams = new URLSearchParams(); | ||
|
|
||
| defaultParams.set('sort', 'age'); | ||
| defaultParams.set('page', '1'); | ||
| defaultParams.set('perPage', '16'); | ||
| setSearchParams(defaultParams, { replace: true }); | ||
| } | ||
| }, []); |
src/pages/AccessoriesPage.tsx
Outdated
| // Стили все в один ебана | ||
| // Вынести статик говно |
|
FaiHamid
left a comment
FaiHamid
left a comment
There was a problem hiding this comment.
Good job!
Let`s just fix a few details:
1.Change button`s styles on hover and when itqm added.
2.Reduce the image zoom on hover.
3.Pagination buttons looks weird.
4.Add hover to capacity
5.The values for all units are not updating — there should be 5 units in the screenshot, but it only shows 2.
|
All issues are fixed |
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
good progress 🚀
here are last improvements 🤞
- active capacity looks broken
- when user change color - product was not found
- make this icon as the link to home page
|
I don't know how you managed this, but you chose a phone model where the 512 GB variant is recorded not as apple-iphone-14-pro-512gb-gold but as apple-iphone-14-pro-512gb There may be other similar issues in the project, but they are exclusively related to .json files. |
etojeDenys
left a comment
etojeDenys
left a comment
There was a problem hiding this comment.
last fixes
- photo is too big at the moment, so scrolling appears
- this link should open in a new tab
- make sure these links work
- it would be better to add some padding to the links so that users can press around the text and it will still work
- add a hover effect to these links
|
What was done:
Questions:
|
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
great job! 🔥
answer to your question about images: you may use any image as you want in this slider, the purpose of this slider is to show your skills, images are not the main point. But if you want you may use any suitable for you images
5 participants
I would ask you to explain the errors and possible improvements in detail. Also, zustand was used in the project instead of redux; unfortunately, I didn't notice that redux or react context needed to be used. If this isn't critical, I would like to keep zustand. I also have a question about mobile layout. When expanding the screen in the range from 320 to 639 pixels, should the content expand or remain with fixed width and height (see screenshot)? If fixed, should the content be centered or aligned to the left edge? Thank you for your answer.
