Develop #877
Open
Develop #877
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2pasha
suggested changes
Jan 29, 2026
2pasha
left a comment
2pasha
left a comment
There was a problem hiding this comment.
great job! 👏
here are some improvements:
- after changing sort params pagination should be reseted
- make this logo as a link to home page also
Comment on lines
31
to
35
| onClick={() => | ||
| isInFavourites | ||
| ? handleProductRemove(product.itemId) | ||
| : handleProductAdd() | ||
| } |
src/components/Dropdown/Dropdown.tsx
Outdated
Comment on lines
91
to
94
| onClick={e => { | ||
| e.stopPropagation(); | ||
| setExpanded(current => !current); | ||
| }} |
Comment on lines
31
to
35
| onClick={() => | ||
| handleProductRemove( | ||
| item.id, | ||
| item.product.priceDiscount * item.quantity, | ||
| ) |
FaiHamid
suggested changes
Feb 9, 2026
FaiHamid
left a comment
FaiHamid
left a comment
There was a problem hiding this comment.
Good job!
Let`s just fix a few details:
1.Footer should be always at the bottom of page.
2.'Total items' must take into account the number of all units of the product.
3.The cursor should be a 'pointer' when hovering over these icons. To make it clear that you can interact with them.
etojeDenys
suggested changes
Feb 10, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK