Develop #876
Develop #876
Conversation
Zibi95
left a comment
Zibi95
left a comment
There was a problem hiding this comment.
Well done. It works well and looks good.
Here are some minor things that i found
- these items in breadcrumb should be centered:
- placeholder and carret are missaligned
- on the phone/tablet here we lack swipe feature
- also here we are missing swipe feature
- this product category pages on mobile look bad. In mockup its different (I was taking screenshot on around +320px)
| return `${namespaceId}-${normCapacity}-${normColor}`; | ||
| }; | ||
|
|
||
| const colorMap: Record<string, string> = { |
There was a problem hiding this comment.
This should be places in some contstant.ts file or smth.
| let data: Product | null = null; | ||
|
|
||
| try { | ||
| const detailResponse = await fetch( |
There was a problem hiding this comment.
Two independent fetch requests happen sequentially, creating a waterfall. These could run in parallel.
src/context/CartContext.tsx
Outdated
| const isInCart = (productId: string | number) => | ||
| cartItems.some(item => item.id === productId); | ||
|
|
||
| const totalCount = cartItems.reduce((sum, item) => sum + item.quantity, 0); |
There was a problem hiding this comment.
btotalCount is recalculated on every render, not just when cartItems changes. Components subscribing to this will re-render unnecessarily.
| useEffect(() => { | ||
| localStorage.setItem('cartItems', JSON.stringify(cartItems)); | ||
| }, [cartItems]); |
There was a problem hiding this comment.
cartItems is an array (non-primitive), causing this effect to run on every render even if data hasn't changed.
|
Powinno być juz lepiej 🫣 |
|
These still not fixed 
|
Zibi95
left a comment
Zibi95
left a comment
There was a problem hiding this comment.
Some of the things are still not fixed
3 participants
DEMO LINK