Skip to content

Conversation

@Beliyandr
Copy link

https://beliyandr.github.io/react_phone-catalog/

I know that I need to add skeleton and another things (

Copy link

@Denys-Kravchuk9988 Denys-Kravchuk9988 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

A few things to improve:

  1. Please use .svg format for icons to have better quality here. And I would recommend to display header on whole page size
Image Image
  1. Please remove default styles for button (waste border)
Image Image Image
  1. Text of icons should be white and border dark
Image Image
  1. Prices should be in a row
Image Image
  1. Please, pay attention for margins
Image Image
  1. Cards should be in a row
Image Image
  1. I would recommend to decrease margin according the design
Image Image
  1. I would recommend to change > symbol for icon from design
Image Image
  1. Here silver borders are cuf off. I would recommend to use silver border as dark border is used and when it's active to update the silver color to dark
Image Image
  1. Margin between text and button is bigger than on design
Image Image
  1. One image is absent
Image
  1. Icon $ is absent and I choose 7 items of phone and the total count is still 1. Also the border around checkout block is absent
Image Image
  1. It seems that the counter doesn't calculate price correctly in case:
  2. I was on cart page and pressed 7 times on plus
  3. Moved back on main page -> choose a new iphone and added it to cart
  4. On this page I see 1 Iphone 7 but price is higher than expected
Image

@Beliyandr
Copy link
Author

https://beliyandr.github.io/react_phone-catalog/

I fixed your recommendetions

Copy link

@etojeDenys etojeDenys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

  1. products in this section should not be discounted
Image
  1. it would be good if the product could be removed from the cart after pressing the button again
Image
  1. price placment looks broken
Image
  1. you should also include the page number in the search parameters
Image
  1. the image is too big at the moment, so scrolling appears
Image
  1. These numbers should be identical.
Image
  1. add a favicon and a title

@Beliyandr
Copy link
Author

https://beliyandr.github.io/react_phone-catalog/

I fixed your new recommendetions

@Beliyandr Beliyandr requested a review from etojeDenys February 1, 2026 19:48
Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

Would you mind to fix this UI issue?

Image

@Beliyandr
Copy link
Author

https://beliyandr.github.io/react_phone-catalog/

I fixed UI issue

Copy link

@Anton-Kuchmasov Anton-Kuchmasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done!

Don't forget to add link to your GitHub profile in Footer (do it before final review)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants