Develop #866
Open
Develop #866
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Implemented Footer component with links to GitHub and home. - Added back-to-top icon functionality. - Created associated SCSS styles for the Footer. - Added PageHeader component for consistent page titles with optional breadcrumbs. - Introduced styles for PageHeader component. - Added up-icon SVG for back-to-top functionality.
…r variables.scss usability in all style files
…rt/favorites functionality
…enhance PageHeader with breadcrumbs
…; remove unused SliderItem component
…s and improve styles; fix price display logic
…duct page and icons
…lay options; add custom select component; improve styles and layout
…Select component with URL search params; update styles
…onComponent; enhance CustomSelect for perPage options
…ion logic and styles; fix perPage handling
…ment product gallery and configurator components; improve styles and layout
…ing for category in API; improve styles for product gallery
…figurator component; enhance styles for Carousel and ProductPage
…nce ProductConfigurator with color and capacity selection
…favorite and cart functionality; update styles for BEM compliance
…tor and slider components; update styles for product details and pricing
…; enhance Navbar with active link styles; improve styles for HomePage and BreadCrumbs
…and BackButton; enhance styles for Cart and Favorites pages; update Navbar with cart item count
… Cart; implement quantity controls in CartItem; update Navbar with total counts
- Implemented `getProductsByIds` to fetch products by their IDs. - Changed favorites state to store product IDs instead of full product objects for better performance. - Updated `Favorites` component to fetch products and display them based on favorites. - Improved styling for the favorites page and added a loader for better user experience. - Removed unused `PhonePage` and `Catalog` components to clean up the codebase. - Updated `NotFoundPage` to use English text for better accessibility. - Refactored `ProductConfigurator` to handle favorites using product IDs. - Created a new `ProductsList` component for better separation of concerns in product rendering.
- Fetch products in Cart component and map them to cart items. - Update CartItemComponent to use CartProduct type for better type safety. - Refactor CartContext to handle itemId as string for consistency. - Implement loading state in ProductPage and display NotFoundPage when product is not found. - Add loader styling in ProductPage module. - Update RecentlyViewed service to store itemId instead of product object. - Improve navigation links in Navbar and Footer for smoother scrolling.
- Introduced loading states in Cart and Favorites components to enhance user experience during data fetching. - Updated styles for loader wrappers to ensure consistent alignment and spacing. - Refactored Favorites component to optimize loading logic based on favorites length. - Enhanced layout structure in Cart and Favorites for better responsiveness.
- Add loading state to Cart component for better user experience. - Implement clearCart function in CartContext for cart management. - Update NotFoundPage to display a loading skeleton while fetching products. - Improve styling for NotFoundPage and Carousel components. - Refactor CustomModal to accept dynamic modal body content.
- Add Button component with customizable styles and props. - Refactor Cart and Product pages to use the new Button component. - Update styles for better alignment and responsiveness. - Improve Cart context logic for handling item quantities. - Enhance NotFoundPage and Slider components with improved styles.
- Add touch event handlers for swipe navigation in the carousel. - Update carousel window styles to improve touch interaction. - Introduce responsive padding for container based on screen size.
- Introduced new mobile banner images for phones, tablets, and accessories. - Updated Carousel component to support responsive images using <picture> and <source> elements. - Enhanced Carousel styling for better layout on mobile devices. - Adjusted layout styles for category sections and cards for improved mobile experience.
- Introduced a new burger menu SVG icon for mobile navigation. - Updated footer styles for better responsiveness and mobile layout. - Enhanced navbar styles to improve layout and added burger menu for mobile. - Adjusted image handling in the footer for better accessibility. - Refined category image styles for hover effects and max dimensions.
…/ if broke smting - discard before this commit - Update cart component to handle loading state when cart is empty. - Introduce ProductsSlider component for displaying products with discounts. - Refactor HomePage to utilize ProductsSlider and improve product display. - Add new styles for ProductsSlider and update existing styles for consistency. - Create Product type definition for better type safety.
- Added Swiper library for enhanced carousel functionality. - Introduced ArrowIcon component for navigation. - Updated ProductsSlider to utilize Swiper for better performance. - Enhanced SliderComponent with touch support for mobile devices. - Refactored styles for consistency and improved layout.
- Upgrade @mate-academy/scripts to version 2.1.3 in package.json. - Refactor ProductsSlider component to utilize ProductCard for better modularity. - Create new ProductCard component with styles and logic for displaying product details. - Implement Menu component for mobile navigation in Navbar. - Add responsive styles for Layout and Menu components. - Remove unused styles and code from ProductsSlider.scss and ProductsSlider.tsx.
- Refactor Menu component to use fixed positioning and add slide-in effect. - Integrate NavLink for navigation within the Menu. - Update Navbar to manage menu state and prevent body scroll when open. - Add links constant for better navigation management. - Replace SliderItem with ProductCard in ProductsList for consistency.
- Adjusted margins and padding in Carousel, HomePage, and Footer components for better alignment on various screen sizes. - Increased gap in category grid for improved spacing. - Modified ProductsSlider styles for better visibility and interaction on desktop. - Refactored Footer component to use a button for the back-to-top functionality, enhancing accessibility. - Updated ProductCard styles for consistent hover effects and spacing. - Introduced new mixin for big-desktop media queries to streamline responsive design.
- Update Favorites and CatalogPage components to use grid layout for better adaptability. - Adjust Navbar styles for improved spacing and responsiveness across devices. - Refactor CustomSelect component to enhance arrow display and maintain consistent width. - Simplify hover effects in ProductCard for better user experience.
- Refactor cart layout to support mobile-first design with grid system. - Update styles for cart items to improve responsiveness and alignment. - Center align h2 text in favorites component for better aesthetics. - Add scroll-to-top functionality on logo and navbar links for better UX.
- Update ProductsSlider to conditionally render controls based on product availability. - Refactor ProductConfigurator styles for consistency and responsiveness. - Enhance ProductGallery styles and structure for improved layout. - Adjust ProductPage styles for better alignment and readability. - Modify PageHeader font sizes for better visibility on different devices.
- Added responsive styles for product configurator and gallery. - Wrapped ProductConfigurator in a new container for better layout. - Improved spacing and alignment for tablet and desktop views.
- Update CarouselIndicator to accept numberOfSlides and setActiveIndex props for better control. - Implement touch swipe functionality in ProductGallery for improved user experience on mobile devices. - Add visually hidden heading for accessibility on HomePage. - Modify PageHeader to conditionally render title based on variant. - Improve styles in ProductPage and HomePage for better layout and responsiveness.
- Introduced a dark mode theme using CSS variables for better user experience. - Updated color variables to support both light and dark themes. - Refactored components to utilize new color variables for consistency. - Enhanced accessibility and readability by adjusting text and background colors. - Improved overall UI by refining styles in various components including buttons, modals, and navigation.
- Update logo dimensions and add padding for better layout. - Implement theme-based logo switching between light and dark modes. - Replace cart icon with an SVG for better scalability and performance. - Adjust global styles for hover background color to improve UI consistency.
- Change fill attribute of arrow SVGs to currentColor for better theming. - Update button border styles in Cart, Carousel, and ProductsSlider components. - Enhance hover effects and responsiveness for buttons in various components. - Refactor color variables for better theme support across the application.
- Update button styles to use CSS variables for better theme support. - Introduce dark mode styles for buttons. - Create FavButton component with hover effects and theming. - Refactor ProductCard to utilize FavButton instead of inline SVG. - Update global styles to include new button variables.
- Refactor ArrowIcon component to support dynamic rotation based on direction. - Update up-icon.svg to use currentColor for better theming. - Modify Footer component to use theme-based logos and integrate ArrowIcon. - Enhance Footer styles for better responsiveness and theme support. - Simplify Navbar by removing unused logo import and adjusting theme handling.
- Update button styles for better hover effects and theming support. - Refactor BackButton to use currentColor for SVG fill. - Revamp CustomSelect component with improved accessibility and theme handling. - Optimize PaginationComponent with memoization and theme integration.
- Replace hardcoded colors with CSS variables for better theming support. - Update button component in Cart to use the new Button component. - Adjust SVG fill color to inherit from current color for consistency. - Minor cleanup in CustomSelect to maintain code clarity.
- Refactor button styles in Cart for improved theming and accessibility. - Update text and border colors in ProductPage for consistency with theme. - Modify background and border styles in CustomModal to align with new design system.
…lity - Change SVG icon colors to use currentColor for better theming. - Set loading state to true by default in ProductPage component. - Refactor Footer styles for smoother transitions and improved hover effects. - Update Navbar styles to use theme variables for consistency. - Adjust PageHeader styles to use CSS variables for text colors.
…lity - Refactor BackButton hover color to use CSS variable for consistency. - Change Menu background and border colors to use CSS variables. - Update Navbar logo and icon components to use SVGs for better scalability. - Enhance Navbar styles for improved layout and responsiveness.
maxim2310
suggested changes
Jan 16, 2026
maxim2310
left a comment
maxim2310
left a comment
There was a problem hiding this comment.
Good work, but lets make some improvement
- all animation with transition works choppy, check why its not work on mouse leave event
- i think you dont need to show loading here when changing colors and memory
- back button has to lead to previous page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO