-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Add solution #4258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add solution #4258
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great job on decomposing the JSX into separate components! The project structure is clean and follows the main requirements. However, a couple of changes are needed before this can be approved. The core goal of this task is to completely separate components and their associated styles. I noticed that the styles for the .header class are located in src/components/Article/Article.css. Please move these styles to the correct file, src/components/Header/Header.css, to ensure each component's styles are fully encapsulated. Additionally, please remember to add the demo link to your pull request description as required by the task instructions.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/components/Article/Article.css
Outdated
| .header { | ||
| text-align: left; | ||
| display: flex; | ||
| justify-content: space-between; | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These styles for the .header class should be in src/components/Header/Header.css, not here. The purpose of this task is to completely separate components and their associated styles.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Excellent work on this task! I am approving your solution as you've successfully decomposed the application into components and correctly organized the styles. All the core requirements have been met, and the code is clean and well-structured.
As a minor suggestion for consistency, you can add import React from 'react'; at the top of your JSX files, such as src/components/Welcome/Welcome.jsx. While not strictly necessary with modern tools, it's a common convention that improves code clarity.
Great job overall!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| import './Welcome.css'; | ||
|
|
||
| // Create a Welcome function returning the HTML of welcome block | ||
| const Welcome = () => ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For consistency with the other components in this project (like Article and Header), it's a good practice to add import React from 'react'; at the top of your JSX files.
Also decomposed the Navigation form Header into a separate file.
DEMO LINK