Develop #4253
Develop #4253
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on this submission, I'm happy to approve it. You've successfully met the core requirements by decomposing the application into Welcome, Header, and Article components, each with its own dedicated styles.
For future reference, a great next step would have been to also extract the navigation logic into its own Navigation component, as suggested in the task description. While your current code works perfectly, creating a separate Navigation component is a key practice for building more modular and maintainable applications.
Overall, this is excellent work. Keep it up!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| .navigation__link { | ||
| display: inline-block; | ||
| outline: none; | ||
| text-decoration: none; | ||
| opacity: 0.7; | ||
| padding: 0 0.5em; | ||
| color: black; | ||
| transition: opacity 0.2s ease-in-out; | ||
| } | ||
|
|
||
| .navigation__link:hover, | ||
| .navigation__link:focus { | ||
| opacity: 1; | ||
| } |
There was a problem hiding this comment.
The task description suggests that you can create a separate Navigation component. To follow this practice of decomposition, it would be better to move these navigation-related styles into a dedicated Navigation.css file within a new Navigation component folder.
| <nav className="navigation"> | ||
| <a className="navigation__link" href="about">About</a> | ||
| <a className="navigation__link" href="services">Services</a> | ||
| <a className="navigation__link" href="contact">Contact</a> | ||
| </nav> |
There was a problem hiding this comment.
Good job creating the Header component. To take this a step further, consider extracting this <nav> block into a separate Navigation component. The task description mentions this as a possibility, and it would improve the modularity of your code.
2 participants
No description provided.