-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Done #4246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Done #4246
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great work on decomposing the application into separate, self-contained components! The project structure is clean and follows the task requirements well.
However, one change is needed. In src/App.jsx, you are rendering the <Navigation /> component, but it is also being rendered inside the <Header /> component. This causes the navigation menu to appear twice on the page.
Please remove the extra <Navigation /> import and component instance from src/App.jsx to resolve this duplication. After that small fix, your solution will be ready for approval!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/App.jsx
Outdated
| <Header /> | ||
| <Welcome /> | ||
| <Article /> | ||
| <Navigation /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Navigation component is already rendered inside the Header component. Including it here again will cause the navigation to appear twice on the page. This line should be removed.
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Excellent work on this submission! I'm happy to approve it. You've done a great job addressing the previous feedback by removing the duplicate Navigation component. The application is now well-structured, with each component and its styles correctly separated. The code is clean and meets all the task requirements. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
DEMO LINK