Compression App (with Node.js)#179
Open
NadiiaBulmak wants to merge 2 commits intomate-academy:masterfrom
Open
Conversation
Anton-Kuchmasov
approved these changes
Sep 6, 2025
Anton-Kuchmasov
left a comment
Anton-Kuchmasov
left a comment
There was a problem hiding this comment.
Well done!
Please check comments below - they might be helpful in your future tasks
src/createServer.js
Outdated
|
|
||
| if (request.method !== 'POST') { | ||
| response.statusCode = 400; | ||
| response.setHeader('Content-Type', 'text/plain'); |
There was a problem hiding this comment.
Better add this header to separate const and add it everywhere in your app
also, you can make a function-wrapper e.g. prepareResponse(statusCode) to add statusCode and headers more consistenly
src/createServer.js
Outdated
Comment on lines
62
to
69
| if (compressionType === 'gzip') { | ||
| compressStream = zlib.createGzip(); | ||
| } else if (compressionType === 'deflate') { | ||
| compressStream = zlib.createDeflate(); | ||
| } else if (compressionType === 'br') { | ||
| compressStream = zlib.createBrotliCompress(); | ||
| } else { | ||
| response.statusCode = 400; |
Author
There was a problem hiding this comment.
Thank you for review! Improvements are pushed! )
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.