Open
Conversation
Anastasiia-Svintsova
suggested changes
May 2, 2023
Comment on lines
67
to
72
| <input | ||
| type="email" | ||
| name="email" | ||
| placeholder="email@example.com" | ||
| required | ||
| > |
Author
|
Anastasiia hi!
When I clik commit changes in your suggestions in GH does the file update automatically:
[cid:5315be95-d085-40a3-92d4-035b420ffff5]
Do I need to make deployment again?
I did all you requested but I am not familiar with Git Hub and sometimes I get lost using it.
________________________________
From: Anastasiia Svintsova ***@***.***>
Sent: Tuesday, May 2, 2023 10:20 AM
To: mate-academy/layout_html-form ***@***.***>
Cc: Sadeni-09 ***@***.***>; Author ***@***.***>
Subject: Re: [mate-academy/layout_html-form] HTML FORM (PR #787)
@Anastasiia-Svintsova requested changes on this pull request.
________________________________
In src/index.html<#787 (comment)>:
+ <input
+ type="text"
+ name="surname"
+ autocomplete="off"
+ >
Check the code style
⬇️ Suggested change
- <input
- type="text"
- name="surname"
- autocomplete="off"
- >
+ <input
+ type="text"
+ name="surname"
+ autocomplete="off"
+ >
________________________________
In src/index.html<#787 (comment)>:
+ <input
+ type="number"
+ name="age"
+ value="12"
+ min="1"
+ max="100"
+ >
⬇️ Suggested change
- <input
- type="number"
- name="age"
- value="12"
- min="1"
- max="100"
- >
+ <input
+ type="number"
+ name="age"
+ value="12"
+ min="1"
+ max="100"
+ >
________________________________
In src/index.html<#787 (comment)>:
+ <input
+ type="date"
+ name="dateOfBirth"
+ value="mm/dd/yyyy"
+ >
Same here
________________________________
In src/index.html<#787 (comment)>:
+ value="12"
+ min="1"
+ max="100"
+ >
+ </label>
+
+ <label for="dateOfBirth" class="form-field">
+ Full date of birth:
+ <input
+ type="date"
+ name="dateOfBirth"
+ value="mm/dd/yyyy"
+ >
+ </label>
+
+ <label for="terms">I accept the term of the agreement
⬇️ Suggested change
- <label for="terms">I accept the term of the agreement
+ <label for="terms">
+ I accept the term of the agreement
________________________________
In src/index.html<#787 (comment)>:
+ <input
+ type="email"
+ name="email"
+ ***@***.***"
+ required
+ >
Same
________________________________
In src/index.html<#787 (comment)>:
+ <input
+ type="password"
+ name="password"
+ required
+ >
Check it everywhere in the code, please
________________________________
In src/index.html<#787 (comment)>:
+ </label>
+ </fieldset>
+
+ <fieldset class="groupField">
+ <legend>Registration:</legend>
+ <label for="email" class="form-field">
+ E-mail:
+ <input
+ type="email"
+ name="email"
+ ***@***.***"
+ required
+ >
+ </label>
+
+ <label for="password">
You don't need to use the for attribute for the label if the element is inside it
⬇️ Suggested change
- <label for="password">
+ <label>
________________________________
In src/index.html<#787 (comment)>:
+ </label>
+ <label>
Don't forget to add empty lines between multiline sibling blocks of HTML
⬇️ Suggested change
- </label>
- <label>
+ </label>
+
+ <label>
________________________________
In src/index.html<#787 (comment)>:
+ <label for="comments" class="form-field">
+ Comments:
⬇️ Suggested change
- <label for="comments" class="form-field">
- Comments:
+ <label for="comments" class="form-field">
+ Comments:
________________________________
In src/index.html<#787 (comment)>:
+ <button type="submit">Submit</button>
+
+ </form>
Don't add spaces between parent and child components.
⬇️ Suggested change
- <button type="submit">Submit</button>
-
- </form>
+ <button type="submit">Submit</button>
+ </form>
—
Reply to this email directly, view it on GitHub<#787 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGMYZXPFZVJJQ62YY6FBJ5LXEC7UXANCNFSM6AAAAAAXSDGH3E>.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
anstsot
suggested changes
May 4, 2023
anstsot
left a comment
anstsot
left a comment
There was a problem hiding this comment.
The previous comments regarding the code style change aren't fixed. could you please fix it?
after changing any file you have to redeploy and rerun the tests.
Sadeni-09
commented
May 8, 2023
Author
Sadeni-09
left a comment
Sadeni-09
left a comment
There was a problem hiding this comment.
Hi, I deployed again the changes requested. Can you please check?
Anastasiia-Svintsova
suggested changes
May 12, 2023
Comment on lines
67
to
72
| <input | ||
| type="email" | ||
| name="email" | ||
| placeholder="email@example.com" | ||
| required | ||
| > |
Comment on lines
102
to
106
| <input | ||
| type="color" | ||
| name="color" | ||
| value="#000000" | ||
| > |
Comment on lines
111
to
115
| <input | ||
| type="time" | ||
| name="timeToBed" | ||
| step="2" | ||
| > |
Comment on lines
129
to
135
| <input | ||
| type="range" | ||
| name="rate" | ||
| min="0" | ||
| max="100" | ||
| value="0" | ||
| > |
|
Hey! If you have any questions feel free to ask them in the chat in Slack |
anstsot
suggested changes
May 16, 2023
anstsot
left a comment
anstsot
left a comment
There was a problem hiding this comment.
Previous comments aren't fixed. If you have any questions, feel free to ask them in the chat
Comment on lines
78
to
82
| <input | ||
| type="password" | ||
| name="password" | ||
| required | ||
| > |
Comment on lines
67
to
72
| <input | ||
| type="email" | ||
| name="email" | ||
| placeholder="email@example.com" | ||
| required | ||
| > |
Comment on lines
129
to
135
| <input | ||
| type="range" | ||
| name="rate" | ||
| min="0" | ||
| max="100" | ||
| value="0" | ||
| > |
Author
|
@anstsot can you please check my latest deploy? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did all changes requested and all tests have passed.
Can you please check?