Conversation
KarolinaWiktoria
commented
Apr 28, 2023
- DEMO LINK
- TEST REPORT LINK
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
Looks very good, needs some tinkering to meet the requirements
src/index.html
Outdated
|
|
||
| <label class="input-row"> | ||
| Surname: | ||
| <input name="surname" autocomplete="off"> |
There was a problem hiding this comment.
Task requirements specify that you should use types attributes, even though inputs by default are type='text' mark it like so explicitly
| <legend>Personal information</legend> | ||
|
|
||
| <label class="input-row"> | ||
| Surname: |
There was a problem hiding this comment.
This way of wrapping with label is kinda unorthodox, I'd suggest in the future do it the "regular way" without wrapping and using 'for' and 'id' attributes for the sake of readability,
There was a problem hiding this comment.
For now just add an empty line between all label titles and inputs e.g.:
<label class="input-row">
Surname:
<input name="surname" autocomplete="off">
</label>Do it for all your labels with inputs
| Yes | ||
| </label> | ||
|
|
||
| <label> |
There was a problem hiding this comment.
Fix the indent:
<label>
<input
type="radio"
name="cats"
value="no"
>
No
</label>
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
Last change and we'r good :)
src/index.html
Outdated
| <input | ||
| type="range" | ||
| name="rate" | ||
| minlength="0" |
There was a problem hiding this comment.
Input type range should have min and max attributes rather than minlength and maxlength, these are more appropriate for inputs with text, for example you want you password to be of some minimal length.
There was a problem hiding this comment.
Okay :). Thank you. I hope now everything is correct :-)
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
I see on the demo that you've adjusted it correctly but I don't see the changes in this pr for some reason, I think you commited these changes to wrong branch or something.
|
hmmm... no Idea ;). Hopefully now you can see it in PR.. Thank you and have a good weekend! :) |
Radoslaw-Czerniawski
left a comment
There was a problem hiding this comment.
Good job, looks perfect :)
|
🙏🏼finally 💪🏼😀 |
