-
Notifications
You must be signed in to change notification settings - Fork 426
initial commit #163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
initial commit #163
Conversation
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Thank you for your hard work! Before your PR can be approved, please address these critical issues: update all feature icon alt attributes in index.html to use descriptive text for accessibility, replace all color.adjust usages in your SCSS files with standard functions like darken, and fix the undefined $c-gray variable in main.scss by using a defined color variable. Once these are fixed, your project will fully meet the requirements—you're almost there! 😊
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Thanks for your hard work! Before your PR can be approved, please replace all uses of color.adjust in your SCSS files (_features.scss, _footer.scss, and _hero.scss) with the standard SCSS function darken as required by the checklist. Once you make these changes, everything else looks great and your code will be fully compliant! Keep going—you’re almost there! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Summary
Great work! 🎉 You have successfully addressed all previously identified issues regarding the use of SCSS color functions. All instances of color.darken in your SCSS files (_features.scss, _footer.scss, _hero.scss) have been correctly replaced with the standard SCSS darken function, fully complying with the checklist requirements. Your code is clean, follows best practices, and there are no unnecessary files or outstanding issues.
Keep up the good work! Remember to always use standard SCSS functions for better compatibility and maintainability. If you encounter similar requirements in the future, you now know how to handle them. Well done—you're ready to move forward! 🚀
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
|
|
||
| &__item-text { | ||
| font-size: 1rem; | ||
| color: color.darken($color-dark, 30%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist issue: Replace color.darken($color-dark, 30%) with the standard SCSS darken($color-dark, 30%) function. The checklist specifies to use the standard SCSS darken function instead of color.darken.
| @import 'vars'; | ||
|
|
||
| .footer { | ||
| background: color.darken($color-light, 5%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist issue: Replace color.darken($color-light, 5%) with the standard SCSS darken($color-light, 5%) function. The checklist specifies to use the standard SCSS darken function instead of color.darken.
|
|
||
| &__copy { | ||
| font-size: 0.88rem; | ||
| color: color.darken($color-dark, 40%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist issue: Replace color.darken($color-dark, 40%) with the standard SCSS darken($color-dark, 40%) function. The checklist specifies to use the standard SCSS darken function instead of color.darken.
| &__subtitle { | ||
| font-size: 1.13rem; | ||
| margin: 1rem 0 2rem; | ||
| color: color.darken($color-dark, 20%); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Checklist issue: Replace color.darken($color-dark, 20%) with the standard SCSS darken($color-dark, 20%) function. The checklist specifies to use the standard SCSS darken function instead of color.darken.
No description provided.