Skip to content

Conversation

@IvanovvvIhor
Copy link

[DEMO LINK](htt ps://IvanovvvIhor.github.io/js_task_parse_list_DOM/)

Copy link

@mateacademy-ai-mentor mateacademy-ai-mentor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Summary

Great work on this task! I am approving your solution as it correctly sorts the list and implements the function to create an array of employee objects, meeting all the core requirements.

One small suggestion for improvement: the getEmployees function is called, but the array it returns is never used. To fully demonstrate that your function works as expected, you could store its return value in a variable and log it to the console, like this: const employees = getEmployees(...items); console.log(employees);. This is a great way to confirm your logic is sound.


✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨

Footnotes

  1. Rate AI review example

}

sortList(...items);
getEmployees(...items);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The getEmployees function is called correctly, but the array it returns is never used. To verify that your function works as expected, you could store its return value in a variable and log it to the console.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants