add task solution #1906
add task solution #1906
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job implementing the core sorting and data extraction logic! The output is correct, which is a great start. However, I'm requesting a change because a specific requirement from the task description was missed. The task asked for a dedicated helper function to handle the conversion of the salary string to a number. Currently, this conversion logic is duplicated in both the sortList and getEmployees functions. Please create a single helper function for this purpose and call it in both places to avoid code repetition. This change is important for practicing code reusability and maintainability.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| const salaryB = Number(b.dataset.salary.replace(/[$,]/g, '')); | ||
| const salaryA = Number(a.dataset.salary.replace(/[$,]/g, '')); |
There was a problem hiding this comment.
This salary conversion logic is duplicated in the getEmployees function as well. The task requirements ask for a dedicated helper function to handle this conversion. Creating a function like parseSalary(salaryString) and calling it in both places would eliminate this code repetition.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this iteration! Your solution is approved. You've successfully addressed the previous feedback by creating a reusable parseSalary helper function, which is a great improvement. The core JavaScript logic now meets all functional requirements perfectly. One minor point for future tasks: please be careful to only modify the files specified in the instructions. In this case, main.css was changed when only main.js should have been. This didn't block the solution, but it's an important detail to watch. Keep up the fantastic work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
No description provided.