Conversation
ATkachenkoA
commented
Jan 31, 2026
ATkachenkoA
commented
- DEMO LINK
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the sorting logic and parsing the employee data! Your solution is very close, but a couple of changes are needed before it can be approved.
The main issue is a small typo in a function name in src/scripts/main.js. The task requires a function named getEmployees, but it's currently named getEmployess. Please correct the spelling to match the requirement.
Additionally, while you call the function, its returned array of employees is not being used. It's a good practice to capture this value and log it to the console, for example: console.log(getEmployees(ulElement));, to verify that your function works as expected.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| itemsArray.forEach((item) => list.appendChild(item)); | ||
| } | ||
|
|
||
| function getEmployess(list) { |
There was a problem hiding this comment.
There's a typo in the function name. The task requires it to be named getEmployees.
src/scripts/main.js
Outdated
|
|
||
| sortList(ulElement); | ||
|
|
||
| getEmployess(ulElement); |
There was a problem hiding this comment.
This function returns an array of employees, but the returned value is not being used. Consider logging it to the console to verify that the function works correctly, for example: console.log(getEmployess(ulElement));.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job addressing the feedback from the previous review! Your solution now meets all the requirements, and the functionality is working perfectly. I am approving your submission.
I have one small suggestion for a minor cleanup. In src/scripts/main.js, the getEmployees function is called twice in a row, but the result of the first call isn't used. You can safely remove this redundant line to make the code a bit cleaner.
This is just a minor tip, and your work is excellent as is. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
|
|
||
| sortList(ulElement); | ||
|
|
||
| getEmployees(ulElement); |
There was a problem hiding this comment.
This call to getEmployees is redundant because its return value is not used. The function is called again on line 41 where the result is correctly passed to console.log. You can safely remove this line.
2 participants
