add task solution #1898
add task solution #1898
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great job on implementing the core logic for sorting and extracting employee data! The code works as expected. However, changes are needed because both the sortList and getEmployees functions don't use the parameters they receive.
Both functions accept a parameter l, but then use the global list variable for their operations (e.g., list.querySelectorAll('li')). This goes against the requirement to create reusable functions that operate on a given list.
Please update both functions to use the l parameter passed to them instead of the global list variable. This will make your functions more robust and align with the task requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| } | ||
|
|
||
| function sortList(l) { | ||
| const items = Array.from(list.querySelectorAll('li')); |
There was a problem hiding this comment.
The function is defined to accept a parameter l, but it uses the global list variable here and on lines 17 and 18. The function should use its parameter l to be reusable as intended by the requirements.
src/scripts/main.js
Outdated
| } | ||
|
|
||
| function getEmployees(l) { | ||
| const items = Array.from(list.querySelectorAll('li')); |
There was a problem hiding this comment.
Similar to the sortList function, this function accepts a parameter l but uses the global list variable instead. Please use the l parameter to select the list items.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work! I am approving this submission. You've successfully addressed the feedback from the previous review, and the code now fully meets all task requirements. Both sortList and getEmployees now correctly use the list parameter passed to them, making them reusable and robust. Great job resolving the issues. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK