Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the list sorting functionality! The visual sorting on the page works perfectly. However, a change is needed in your getEmployees function. Currently, it uses Number(li.dataset.salary) to convert the salary, but this results in NaN because the string format is '$2,500'. This fails to meet the requirement for the employee object schema. To fix this, please reuse your getSalary helper function inside getEmployees, as it already handles this conversion correctly. After that small fix, your solution will be complete.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| const object = { | ||
| name: li.textContent.trim(), | ||
| position: li.dataset.position, | ||
| salary: Number(li.dataset.salary), |
There was a problem hiding this comment.
The salary from li.dataset.salary is a string that includes characters like $ and , (e.g., '$2,500'). The Number() function cannot parse this format and will return NaN. Consider reusing your getSalary helper function here, which is already designed to handle this specific string format correctly.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I am happy to approve your solution. You've successfully addressed the feedback from the previous review by reusing the getSalary helper function within getEmployees, ensuring the salary is parsed correctly. The code is clean, well-structured, and meets all the project requirements. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK