Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on this test suite! You've successfully covered all the examples from the description and added some excellent edge cases. I am approving your solution as it meets all the requirements. One small piece of feedback for the future: the test case for splitInteger(0, 1) isn't strictly necessary, as the task description specifies the function will only receive positive integers. While testing edge cases is an excellent habit, it's best to focus on the scenarios defined by the function's contract. Overall, this is a very solid submission. Well done!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
| when splitting into 1 part`, () => { | ||
|
|
||
| expect(splitInteger(8, 1)).toEqual([8]); | ||
| expect(splitInteger(0, 1)).toEqual([0]); |
There was a problem hiding this comment.
The task description specifies that the value argument will always be a positive integer. While testing edge cases like 0 is a good habit, in this case, it's outside the function's contract as defined by the requirements, so this test case is not needed.
2 participants
No description provided.