-
Notifications
You must be signed in to change notification settings - Fork 1.1k
solution #1060
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
solution #1060
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,18 +4,26 @@ const splitInteger = require('./splitInteger'); | |
|
|
||
| test(`should split a number into equal parts | ||
| if a value is divisible by a numberOfParts`, () => { | ||
|
|
||
| expect(splitInteger(8, 1)).toEqual([8]); | ||
| expect(splitInteger(6, 2)).toEqual([3, 3]); | ||
| expect(splitInteger(20, 4)).toEqual([5, 5, 5, 5]); | ||
| }); | ||
|
|
||
| test(`should return a part equals to a value | ||
| when splitting into 1 part`, () => { | ||
|
|
||
| expect(splitInteger(20, 1)).toEqual([20]); | ||
| expect(splitInteger(17, 4)).toEqual([4, 4, 4, 5]); | ||
| expect(splitInteger(32, 6)).toEqual([5, 5, 5, 5, 6, 6]); | ||
| }); | ||
|
|
||
| test('should sort parts ascending if they are not equal', () => { | ||
| test(`should sort parts ascending if they are not equal`, () => { | ||
| const result = splitInteger(21, 4); | ||
|
|
||
| expect(result).toEqual([5, 5, 5, 6]); | ||
| }); | ||
|
|
||
| test('should add zeros if value < numberOfParts', () => { | ||
| test(`should add zeros if value < numberOfParts`, () => { | ||
| const result = splitInteger(3, 4); | ||
|
|
||
| expect(result).toEqual([0, 1, 1, 1]); | ||
| }); | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Great work on the existing tests! To fully meet the requirements, please add tests for all the specific examples provided in the task description, such as |
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test description is a bit confusing because it only describes the first assertion. The assertions on lines 15 and 16 test cases where the value is split into multiple, unequal parts. Consider moving them to the
'should sort parts ascending if they are not equal'test block to keep related tests together.