Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Your tests are well-structured and cover several important scenarios, which is a great start. However, changes are needed because a core requirement of the task has not been met. The task description explicitly requires tests for four specific examples, which are currently missing from your test suite.
Please add the following test cases to src/splitInteger.test.js to complete the requirements:
splitInteger(8, 1)splitInteger(6, 2)splitInteger(17, 4)splitInteger(32, 6)
Once these tests are added, your solution will fully meet the task objectives. Keep up the good work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| test(`should split a number into equal parts | ||
| if a value is divisible by a numberOfParts`, () => { | ||
| const value = 100; |
There was a problem hiding this comment.
The tests you've written are logical and cover different scenarios. However, the requirements specify four exact examples that must be tested. Please add test cases for splitInteger(8, 1), splitInteger(6, 2), splitInteger(17, 4), and splitInteger(32, 6).
2 participants
No description provided.