add task solution #2168
add task solution #2168
Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Great work on implementing the core logic to calculate the total and average population! The code works correctly for the current data.
However, I am requesting changes because one key requirement hasn't been fully met: ensuring the string can be converted to a number before the conversion. Your current implementation doesn't validate the input. If a span contained non-numeric text, Number() would produce NaN, causing the total and average to display incorrectly as NaN.
To fix this, please add logic to handle cases where the text content is not a valid number. A good approach would be to filter out any non-numeric values before you calculate the sum. This will make your solution more robust and fully meet the task's requirements.
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
src/scripts/main.js
Outdated
| const populations = [...populationElements].map((el) => { | ||
| const text = el.textContent.trim(); | ||
|
|
||
| return Number(text.replace(/,/g, '')); | ||
| }); |
There was a problem hiding this comment.
The code works correctly for the given HTML, but it doesn't fully meet the requirement: "Make sure that the given string can be converted to a number". If one of the span elements contained non-numeric text, Number() would produce NaN, which would then make the total and average NaN. You should add a check to handle cases where the text content cannot be converted to a valid number, for example by filtering out invalid values.
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Excellent work on this task! I am approving your solution as it successfully meets all the requirements. You've done a great job implementing the logic for parsing, calculating, and formatting the population data. I'm particularly impressed with how you addressed the feedback from the last review by adding robust validation using .filter() and Number.isFinite(). This has made your code much more reliable. Keep up the great work!
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Footnotes
2 participants
DEMO LINK