Conversation
mateacademy-ai-mentor
left a comment
mateacademy-ai-mentor
left a comment
There was a problem hiding this comment.
Review Summary
Hey there! 👋 The join method you've implemented works correctly, which is great! However, could you refactor the code to avoid using nested if statements? The checklist specifically mentions this point for code style. Also, extending the Array prototype is generally discouraged because it can lead to compatibility issues. Let's aim for cleaner and more maintainable code! You got this! 💪
✨ Please rate this review in the Platform's notification center1. I will be grateful for your feedback! ✨
Important
Fix the issues, commit the changes, and then re-request my review using the Re-request review button2 in the Reviewers tab.
Tip
If you have any comments about this review, please leave a message in the Add a comment section below and mention me with the @mateacademy-ai-mentor tag3.
I will read your message during my next review of your pull request. Please do not reply directly to my comments, as that feature is not supported yet.
Caution
Do not close the pull request until the review is complete. Closing it early can lead to unexpected behavior and disrupt the review process.
Footnotes
|
|
||
| if (!lastElement) { | ||
| joinedString += separator; | ||
| } |
There was a problem hiding this comment.
The current implementation uses nested if statements. According to the checklist, you should avoid nested if statements:
- [CODE STYLE] - avoid using nested
ifstatements, we are sure that you can do it without them :)
2 participants
No description provided.