Open
Conversation
roman-mirzoian
suggested changes
Aug 17, 2023
roman-mirzoian
left a comment
roman-mirzoian
left a comment
There was a problem hiding this comment.
Good job, but there is quite a bit of work to be done.
src/arrayMethodJoin.js
Outdated
Comment on lines
11
to
13
| if (this[i] !== null && this[i] !== undefined) { | ||
| resultString += this[i]; | ||
| } |
There was a problem hiding this comment.
We use this[i] three times, so we can put it in a variable.
src/arrayMethodJoin.js
Outdated
| [].__proto__.join2 = function(separator) { | ||
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| let resultString = ''; |
There was a problem hiding this comment.
The variable name is fine, but I would add a more precise name.
Suggested change
| let resultString = ''; | |
| let joinedString = ''; |
roman-mirzoian
suggested changes
Aug 17, 2023
src/arrayMethodJoin.js
Outdated
| // write code here | ||
| [].__proto__.join2 = function(separator = ',') { | ||
| let joinedString = ''; | ||
| let value = []; |
There was a problem hiding this comment.
It is not necessary to bring the definition of a variable that is used in the middle of the loop outside.
You should also think about better naming.
Moroz-Dmytro
approved these changes
Aug 18, 2023
| let joinedString = ''; | ||
|
|
||
| for (let i = 0; i < this.length; i++) { | ||
| const valueOfArray = this[i]; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.