Skip to content

Conversation

@YuriiHoliuk
Copy link
Contributor

Summary

  • Refactored ESLint configuration to use @stylistic/eslint-plugin for formatting rules
  • Extracted formatting rules into separate rules.js files for better maintainability
  • Added @Stylistic plugin dependency to both internal and react-internal configs
  • Updated package versions to 1.4.0
  • Maintained existing rule behavior while improving code organization

Test plan

  • Verify ESLint still works correctly with existing projects
  • Confirm all formatting rules are properly applied
  • Test both internal and react-internal configurations
  • Run linting on sample projects to ensure no regressions

🤖 Generated with Claude Code

@YuriiHoliuk YuriiHoliuk requested review from a team September 29, 2025 13:43
- Extract formatting rules into separate rules.js files
- Add @stylistic/eslint-plugin dependency to both configs
- Replace individual formatting rules with centralized formattingRules
- Bump package versions to 1.4.0
- Maintain existing rule behavior while improving maintainability

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@YuriiHoliuk YuriiHoliuk force-pushed the PF-9152_improve-formatting branch from 564e111 to 32b8d66 Compare September 29, 2025 13:44
Copy link
Contributor

@marina-tilniak marina-tilniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do we need it? would be good to add it to pr description

@YuriiHoliuk
Copy link
Contributor Author

why do we need it? would be good to add it to pr description

@marina-tilniak It would be clear in the case of the right timing. It's used in api, frontend, mobile for months, I just realized, I have uncommitted changes locally, when needed to publish mate-scripts for our external mentors :harold:
That's part of the thing I did with formatter and migrated back to pure ESLint, but with more styling rules.

@marina-tilniak
Copy link
Contributor

why do we need it? would be good to add it to pr description

@marina-tilniak It would be clear in the case of the right timing. It's used in api, frontend, mobile for months, I just realized, I have uncommitted changes locally, when needed to publish mate-scripts for our external mentors :harold: That's part of the thing I did with formatter and migrated back to pure ESLint, but with more styling rules.

I see, bur I mean why do we need Stylistic plugin?

@YuriiHoliuk
Copy link
Contributor Author

why do we need it? would be good to add it to pr description

@marina-tilniak It would be clear in the case of the right timing. It's used in api, frontend, mobile for months, I just realized, I have uncommitted changes locally, when needed to publish mate-scripts for our external mentors :harold: That's part of the thing I did with formatter and migrated back to pure ESLint, but with more styling rules.

I see, bur I mean why do we need Stylistic plugin?

Styling rules in eslint are deprecated in prior of this plugin. And it contains more rules to autofix formatting to the desired state, to be closer to formatters.

@YuriiHoliuk YuriiHoliuk merged commit 120497a into master Sep 30, 2025
1 check passed
@YuriiHoliuk YuriiHoliuk deleted the PF-9152_improve-formatting branch September 30, 2025 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants