Develop #45
Open
Develop #45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varseniuk
suggested changes
Jan 31, 2022
varseniuk
left a comment
varseniuk
left a comment
There was a problem hiding this comment.
При такій ширині було б варто розташувати ці пункти в два стовбчика, бо дуже багато вільного простору справа залишається
При певній ширині текст обрізається справа
Зарано ці зображення починають ставати у стовбчик. Можна для початку розташувати їх у два ряди, а на вужчих екранах - вже у стовбчик
danylo-onishchuk
previously requested changes
Feb 7, 2022
danylo-onishchuk
left a comment
danylo-onishchuk
left a comment
There was a problem hiding this comment.
комменты от Виталия не повикшены. возможно работа не задеплоина была заново
Author
|
сделал npm run deploy. |
aliceblunt8
previously requested changes
Feb 11, 2022
aliceblunt8
left a comment
aliceblunt8
left a comment
There was a problem hiding this comment.
- нужно дать id секциям, чтобы ссылки работали как якоря на странице
сейчас они никуда не ведут
- на всех кнопка нет ховер эффектов, только pointer
нужно добавить
-
добавь
scroll-behavior: smooth;на весь html для медленной прокрутки
https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior -
давай сделаем иконки ссылками на соцсети и чтобы они открывались в новой вкладке
varseniuk
approved these changes
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEMO LINK