Digits v1 #39
Open
Digits v1 #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
varseniuk
suggested changes
Dec 21, 2021
varseniuk
left a comment
varseniuk
left a comment
There was a problem hiding this comment.
В цілому - хороша робота.
Ось декілька нюансів, які варто пофіксити:
Колір цих іконок має бути різний
Заголовки відповідно до дизайну мають мати більш жирний нарис
Імена людей мають бути жирнішими
Ці заголовки у футері також
Логотип у футері має бути клікабельним
aliceblunt8
suggested changes
Dec 28, 2021
aliceblunt8
left a comment
aliceblunt8
left a comment
There was a problem hiding this comment.
good job!
- mobile menu doesn't open on click
- buttons on the hero section should lead somewhere on click (to pricing and products sections I guess)
- add
scroll-behavior: smooth;to the whole page
https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-behavior - nothing happens when I click on the phone number, but it should prompt me to call this number from any device
- social links should be opened in a new tab
Author
|
но єти все задания не были указаны. было написано адаптировать под все экраны |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://lesiaaa.github.io/Digits/