Skip to content

fix: dual-mode VIP wedge visibility and snatched item disabling#29

Merged
masonfox merged 6 commits intomainfrom
fix/dual-mode-vip-wedge-and-snatched-disable
Feb 12, 2026
Merged

fix: dual-mode VIP wedge visibility and snatched item disabling#29
masonfox merged 6 commits intomainfrom
fix/dual-mode-vip-wedge-and-snatched-disable

Conversation

@masonfox
Copy link
Owner

Summary

  • Hide FL Wedge toggle for VIP torrents in dual-select mode — VIP torrents already have freeleech, so offering a wedge toggle was misleading. Applies to both desktop (DualSearchResultsList) and mobile (MobileBottomSheet) dual flows.
  • Consolidate wedge visibility logic — Extracted wedge visibility into clear boolean variables (showBookWedge, showAudiobookWedge) and removed an unnecessary separator in the dual-mode header.
  • Disable snatched items in dual-select flow — Previously, "Snatched Already" items could be selected and downloaded in the dual flow despite being disabled in the single flow. Now snatched items are visually muted (opacity-50, cursor-not-allowed), non-interactive (no click/keyboard handlers), and guarded at the handler level (handleSelectBook, handleSelectAudiobook, handleDualDownload).
  • Bump to v2.5.3

Changes

File Change
app/components/SearchResultItem.jsx Block click/keyboard selection for snatched items in selectable mode; apply disabled styling
app/page.jsx Guard dual-mode selection and download handlers against snatched items
app/components/DualSearchResultsList.jsx Extract wedge visibility logic; exclude VIP and snatched items from wedge toggles; remove separator
app/components/MobileBottomSheet.jsx Exclude VIP items from wedge toggles
app/components/DualDownloadButton.jsx Removed (unused)
package.json Bump version to 2.5.3

@codecov
Copy link

codecov bot commented Feb 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refines the dual-select (book + audiobook) flow by tightening FL wedge toggle visibility (especially for VIP torrents) and preventing selection/download of already-snatched items, aligning dual-mode behavior with single-mode behavior.

Changes:

  • Hide FL wedge toggles for VIP torrents (desktop dual list + mobile bottom sheet) and consolidate wedge-visibility logic.
  • Prevent snatched items from being selectable in dual-select UI, and add handler-level guards to block snatched selections/downloads.
  • Remove unused DualDownloadButton component and bump version to 2.5.3.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
package.json Version bump to 2.5.3.
app/page.jsx Adds guards to prevent selecting/downloading snatched items in dual mode.
app/components/SearchResultItem.jsx Blocks click/keyboard selection for snatched items and applies disabled styling in selectable mode.
app/components/DualSearchResultsList.jsx Centralizes wedge visibility logic; hides wedges for VIP/snatched; simplifies header layout.
app/components/MobileBottomSheet.jsx Hides wedge toggles for VIP torrents in dual flow on mobile.
app/components/DualDownloadButton.jsx Removed unused component.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

…h PropType

Derive effective wedge values at request time to ensure wedges are only
purchased for eligible items (not already freeleech, VIP, or snatched),
preventing waste when wedge state persists across selection changes.

Also add freeleech to resultShape PropTypes in dual-mode components for
consistency with SearchResultItem and complete data-shape validation.
@masonfox masonfox merged commit 166fedd into main Feb 12, 2026
3 checks passed
@masonfox masonfox deleted the fix/dual-mode-vip-wedge-and-snatched-disable branch February 12, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments