-
Notifications
You must be signed in to change notification settings - Fork 0
[FEAT] 질문이 생성된 PR만 반환되도록 수정 #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
1f22601
feat: 프레세싱 상태 추가
coli-geonwoo 8749dd6
feat: 프로세싱 update 로직 추가
coli-geonwoo b0e44ba
feat: prCount를 update가 쳐졌을 때 증가
coli-geonwoo 3b3157e
feat: 단일 PR 조회 시 질문 생성 상태 같이 반환
coli-geonwoo 65797e6
feat: 질문 생성이 완료된 PR만 찾아오도록 로직 수정
coli-geonwoo aabc4b3
test: 질문 생성이 완료된 PR만 찾아오는 테스트 추가
coli-geonwoo 4442b42
test: 상태에 대한 검증 추가
coli-geonwoo 1ba01aa
refactor: recordStatus를 필드값을 활용하도록 수정
coli-geonwoo f8a5a86
refactor: 마이그레이션을 위한 default 값 저장
coli-geonwoo d0bb389
refactor: page.get() > stream() 으로 변경
coli-geonwoo 821ae0c
fix: 마이그레이션을 위한 default 값을 문자열로 지정
coli-geonwoo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -3,6 +3,7 @@ | |
| import static org.assertj.core.api.Assertions.assertThat; | ||
|
|
||
| import com.devoops.BaseServiceTest; | ||
| import com.devoops.domain.entity.github.pr.ProcessingStatus; | ||
| import com.devoops.domain.entity.github.repo.GithubRepository; | ||
| import com.devoops.domain.entity.github.pr.PullRequest; | ||
| import com.devoops.domain.entity.github.pr.RecordStatus; | ||
|
|
@@ -25,8 +26,13 @@ class UpdateToDone { | |
| void 풀_리퀘스트_회고_상태를_완료로_변경한다() { | ||
| User user = userGenerator.generate("김건우"); | ||
| GithubRepository repo = repoGenerator.generate(user, "건우의 레포"); | ||
| PullRequest pullRequest = pullRequestGenerator.generate("최초 PR", RecordStatus.PENDING, repo, | ||
| LocalDateTime.now()); | ||
| PullRequest pullRequest = pullRequestGenerator.generate( | ||
| "최초 PR", | ||
| RecordStatus.PENDING, | ||
| ProcessingStatus.DONE, | ||
| repo, | ||
| LocalDateTime.now() | ||
| ); | ||
|
Comment on lines
+29
to
+35
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🛠️ Refactor suggestion 시그니처 변경 반영 LGTM + 서비스 레벨 필터 테스트 제안 레코드 상태 업데이트 테스트는 적절합니다. 추가로 “서비스 계층에서 PR 목록/조회 시 PROCESSING 제외”를 검증하는 테스트를 보강해 주세요(예: getProcessed… 계열 메서드가 DONE만 반환). 🤖 Prompt for AI Agents |
||
|
|
||
| PullRequest updatedPullRequest = pullRequestService.updateStatus(pullRequest.getId(), RecordStatus.DONE); | ||
|
|
||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
시그니처 변경 반영 LGTM + 교차 시나리오 테스트 제안
이 컨트롤러는 회고 수정 API를 다루지만, 본 PR의 핵심(처리 완료 PR만 노출)을 시스템 관점에서 담보하려면 PR 목록/조회 컨트롤러에 PROCESSING 배제 E2E 테스트를 추가해 주세요.
🤖 Prompt for AI Agents