♻️ Extract wallet to context #193
Conversation
| setError((e as Error).message); | ||
| setCurrentState(State.ERROR); | ||
| } | ||
| }, [data, state.p2pClient, state.attemptedInitialLogin]); |
There was a problem hiding this comment.
Why state.attemptedInitialLogin is no more required?
Deploying tzsafe-ui-ghostnet with
|
| Latest commit: |
e7811ab
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://32076319.tzsafe-ui.pages.dev |
| Branch Preview URL: | https://extract-wallet-to-context.tzsafe-ui.pages.dev |
Pilou97
left a comment
Pilou97
left a comment
There was a problem hiding this comment.
Cool to have update the package.json and airgap
| case "p2pConnect": { | ||
| return { ...state, p2pClient: action.payload }; | ||
| } | ||
| case "addDapp": { | ||
| if (!state.address) return state; |
There was a problem hiding this comment.
The address is always defined? I don't know what is addDapp but can it be triggered when the user is disconnected without any safe?
There was a problem hiding this comment.
address is no longer defined in the global state but in wallet context.
addDapp allows to connect an external dapp with Tzsafe and user have to import a contract to access to this feature, so I believe disconnected user cannot trigger this action
| action: BUY_ADDRESS.name, | ||
| description: ( | ||
| <p> | ||
| TzSafe doesn't support the entrypoint:{" "} |
There was a problem hiding this comment.
You don't need spaces anymore? I am wondering if we can use template string 🤔
There was a problem hiding this comment.
Yes you're right :-)
There was a problem hiding this comment.
I updated all of occurrences of this string
| expect(storage.owners).toEqual([owner]); | ||
| storage.metadata.get("").then((value: string) => { | ||
| expect(value).toEqual(char2Bytes(ipfs_file)); | ||
| expect(value).toEqual(stringToBytes(ipfs_file)); |
There was a problem hiding this comment.
what is the difference between char2Bytes and stringToBytes ? Why do we need to change it?
There was a problem hiding this comment.
charToBytes and bytesToChar are deprecated => https://taquito.io/typedoc/functions/_taquito_utils.char2Bytes
TODO : Problem with fetching proposals ... To be continued ...