changes for ghcr updates, code-docs formatting docker group, improve harbor installation, prometheus scrape issue #200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove HB MVP Pattern section from README Removed detailed explanation of the HB MVP pattern from the README. * Revise setup guide for clarity and update clone command Updated the setup guide to clarify the steps for downloading setup files and modified the git clone command to use sparse checkout. * Revise setup guide for Setup Files download steps Updated instructions for downloading the repository and adjusted sparse checkout commands. * updated image name with ghcr * Run Symphony API from GHCR image instead of local build * Build docker device image from GHCR instead of local build * changed device-agent naming to wfm-client * Removed some **Notes as per review comments * Handled review comments (Readded some removed code) * Removed commented code and changed Symphony image ref to WFM Image as per review comments Updated workload Fleet Management Client image references and removed commented build logic. * Add GitHub Actions workflow for testing * Add GitHub Actions workflow for building Docker image for GHCR * Add build script for workload fleet client * Added a missing utility function --------- Co-authored-by: sanjujunnuthula <sanjuvardhan.junnuthula@capgemini.com>
* changes on shallow cloning * updated .md files --------- Co-authored-by: vireshnavalli <viresh-r.navalli@capgemini.com>
Running as non-root, if the user is added to the `docker` group in the script, a new shell session is needed. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
Make the installation as non-root possible. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
* add go formatting Add tooling to ensure Go sticks to expected format: * devcontainer to run on a standardized environment * justfile to easily format locally * GitHub workflow to check format on CI Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * format go code according specification Apply Go format on all Go source code files. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * add go vet Go vet helps finding subtle issues in Go code. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * add editorconfig Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * apply format to yaml files Apply editorconfig format to YAML files. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * apply format to markdown files Apply format according editorconfig. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> * apply format to bash files Apply format according editorconfig to Bash files. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> --------- Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com> Co-authored-by: Viresh Navalli <viresh-r.navalli@capgemini.com>
Make verbosity cloning git repositories uniform with other messages. Signed-off-by: Silvano Cirujano Cuesta <silvano.cirujano-cuesta@siemens.com>
vireshnavalli
changed the title
vireshnavalli
changed the title
4 tasks
* fix: push based prometheus scraping
vireshnavalli
changed the title
4 tasks
singhmj-1
approved these changes
Jan 29, 2026
nitin-parihar
previously approved these changes
Jan 29, 2026
nitparihar
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ghcr updates - Sandbox release available as docker container images on GHCR
changes on shallow cloning - Selectively pull specific files instead of a clone of entire Sandbox while building the Sandbox
new session needed to activate docker group - Changes for allowing sudoless docker install
improve harbor installation - Changes for allowing sudoless harbor install
Add go formatting and editorconfig format - uniform formatting changes
uniform verbosity of git clones
The current configuration has Prometheus running on the WFM scraping metrics from the device. This breaks our network communication restrictions so we need to update this to push the metrics from the device to the WFM.