This repository was archived by the owner on Mar 5, 2024. It is now read-only.
HUB-441 #9
Open
HUB-441 #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iskripka
reviewed
Dec 12, 2022
|
|
||
| $builder = new OpenApiResolverBuilder( | ||
| new \ArrayObject(), | ||
| new \ArrayObject([new NumberMinimumValidator(), new NumberMaximumValidator()]), |
There was a problem hiding this comment.
Вынести \ArrayObject в импорт во все местах
iskripka
reviewed
Dec 12, 2022
| $this->expectException(RuntimeException::class); | ||
| ParameterCollectionFormatEnum::getDelimiter('_undefined_'); | ||
| } | ||
| } No newline at end of file |
iskripka
reviewed
Dec 12, 2022
| 'class', | ||
| ]); | ||
| } | ||
| } No newline at end of file |
iskripka
reviewed
Dec 12, 2022
| 'string', | ||
| ]); | ||
| } | ||
| } No newline at end of file |
iskripka
reviewed
Jan 4, 2023
Tests/EnumTest/EnumParameterTest.php
Outdated
| $fieldType = 'string'; | ||
|
|
||
| $builder = new OpenApiResolverBuilder( | ||
| new \ArrayObject(), |
iskripka
reviewed
Jan 4, 2023
| /** | ||
| * @var ArrayMaxItemsValidator | ||
| */ | ||
| private $sut; |
There was a problem hiding this comment.
Почему sut? похож на validator
строгая типизация вместо аннотации
iskripka
reviewed
Jan 4, 2023
| /** | ||
| * @var ArrayMinItemsValidator | ||
| */ | ||
| private $sut; |
iskripka
reviewed
Jan 4, 2023
| use OpenApi\Annotations\Property; | ||
| use Symfony\Bundle\FrameworkBundle\Test\KernelTestCase; | ||
| use Symfony\Component\OptionsResolver\Exception\InvalidOptionsException; | ||
| use function str_repeat; |
iskripka
reviewed
Jan 4, 2023
| use OpenApi\Annotations as OA; | ||
|
|
||
| /** | ||
| * @OA\Schema( |
There was a problem hiding this comment.
А эти моки где нибудь используются? не нашел тест на них
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.