Allow users to place the menu somewhere other then the default place.#3
Open
codekipple wants to merge 1 commit intomarcopeg:masterfrom
codekipple:master
Open
Allow users to place the menu somewhere other then the default place.#3codekipple wants to merge 1 commit intomarcopeg:masterfrom codekipple:master
codekipple wants to merge 1 commit intomarcopeg:masterfrom
codekipple:master
Conversation
…on for the menus placement, the menu is passed into the users function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I needed to place the menu outside of the menu wrapper. I added a config option that lets the user pass a function and handle the placement of the menu themselves.
I decided to use a function rather then have the user specify a selector because it then enables the user to use any of the jQuery DOM insertion functions (append, prepend ect.)