-
Notifications
You must be signed in to change notification settings - Fork 35
Type upgrade #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Type upgrade #65
Conversation
|
Hi, @doncem! The overall idea looks fine to me. Do you need any help? |
|
repo needs unit test upgrade to allow php5 and php7 support in travis. for php7 it picks up PHPUnit v6.x which only supports this version. you can see in build report. could work on a hack to apply in this PR but lacking time last couple days and probably best to make more solid decision and code change so |
|
Ok. I'll try to add phpunit as a dev dependency ASAP there is time, so we won't depend on Travis environment anymore. |
|
There is a "one-liner" solution: |
personally, not fancying the addition of the public function to the ParserInterface, kind of breaks the abstraction "parser should not know a thing about the types". but the fact of having a lookup is very helpful