Skip to content

Conversation

@doncem
Copy link

@doncem doncem commented Apr 29, 2017

  • simplified default types registration
  • introducing container for type instantiation
  • default types are singletons
  • type upgrade is backwards compatible
  • allowing to register namespace lookup for simplified ConcreteType usage \Without\Absurdly\Long\Custom\Namespace\For\The\Annotation\Classes

personally, not fancying the addition of the public function to the ParserInterface, kind of breaks the abstraction "parser should not know a thing about the types". but the fact of having a lookup is very helpful

@coveralls
Copy link

Coverage Status

Coverage decreased (-38.2%) to 51.84% when pulling 1a919ac on doncem:type-upgrade into 675bc47 on marcioAlmada:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+1.03%) to 91.104% when pulling 22eb0ed on doncem:type-upgrade into 675bc47 on marcioAlmada:master.

@marcioAlmada
Copy link
Owner

marcioAlmada commented May 2, 2017

Hi, @doncem! The overall idea looks fine to me. Do you need any help?

@doncem
Copy link
Author

doncem commented May 3, 2017

repo needs unit test upgrade to allow php5 and php7 support in travis. for php7 it picks up PHPUnit v6.x which only supports this version. you can see in build report.

could work on a hack to apply in this PR but lacking time last couple days and probably best to make more solid decision and code change so minime/annotations could support all these versions

@marcioAlmada
Copy link
Owner

marcioAlmada commented May 3, 2017

Ok. I'll try to add phpunit as a dev dependency ASAP there is time, so we won't depend on Travis environment anymore.

@doncem
Copy link
Author

doncem commented May 10, 2017

There is a "one-liner" solution: class_alias('PHPUnit\\Framework\\TestCase', 'PHPUnit_Framework_TestCase');. I'll leave it up to you to decide and afters I can rebase the PR

Repository owner deleted a comment Feb 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants