Draft
Conversation
added 30 commits
September 9, 2022 09:58
…_pose_motion example TODO: * make the logger compatible * get rid of code duplication * Make FR3 actually use FR3 data type * Fix warnings and lints * make other examples work * Fix documentation
9e7214b to
8eaa2a7
Compare
8eaa2a7 to
03af643
Compare
Welcome to Codecov 🎉Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment. Thanks for integrating Codecov - We've got you covered ☂️ |
623a86f to
7c1d5ce
Compare
added 5 commits
October 20, 2023 11:23
d66cf66 to
708b065
Compare
added 6 commits
October 30, 2023 09:32
The Robot trait does not need a Model type anymore. Instead, it uses the RobotModel struct, which is an abstraction over the model for panda and fr3. Since currently fr3 and panda can work with the type, the RobotModel is also used internally. Should at a later point those two become incompatible, the internal model can be replaced with a type that converts into RobotModel
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Huge Pr to allow the use FR3 and Panda. They are separate structs and can be abstracted over the RobotWrapper type.
Example
The examples are already working and the usage for end-users is as I intended. However, there are still things to do:
gripper::tests::gripper_read_onceis failing on CI