Conversation
- Add loading screen between setup and application displays - Change order of screen init on application display
Author
|
I made this request ages ago, and apparently my account has been shadow blocked so it wasn't visible. It should be unblocked now. Regarding this commit I'll update it to the current main branch at some point if feature still needed (haven't looked to see if you've done this already!) |
Owner
|
Thanks for your PR, unfortunately I have only just been able to see it because of your 'shadow block'. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Effect:
Once
application_mode()is called,loadingScreen()is called prior toorangeClock.main(), showing a new screen telling user the IP address OrangeClock is connected as (to show them connection was successful), and informing them that the main screen is loading.In order to stop the display from being erased once
orangeClock.main()is called,displayInit()has been moved to within the process loop of the main display. To prevent repeated initialisation, a flag has been added which tracks whether the main loop is the first occurrence (subsequent loops do not call the init).Feedback and changes welcome
M