Skip to content

Comments

Loading Screen#32

Open
Myarlathotep wants to merge 1 commit intomarc3linho:mainfrom
Myarlathotep:loading
Open

Loading Screen#32
Myarlathotep wants to merge 1 commit intomarc3linho:mainfrom
Myarlathotep:loading

Conversation

@Myarlathotep
Copy link

Proposed changes:

  • Add loading screen between setup and application displays
  • Change order of screen init on application display

Effect:
Once application_mode() is called, loadingScreen() is called prior to orangeClock.main(), showing a new screen telling user the IP address OrangeClock is connected as (to show them connection was successful), and informing them that the main screen is loading.

In order to stop the display from being erased once orangeClock.main() is called, displayInit() has been moved to within the process loop of the main display. To prevent repeated initialisation, a flag has been added which tracks whether the main loop is the first occurrence (subsequent loops do not call the init).

Feedback and changes welcome

M

- Add loading screen between setup and application displays
- Change order of screen init on application display
@Myarlathotep
Copy link
Author

Myarlathotep commented Feb 18, 2024

I made this request ages ago, and apparently my account has been shadow blocked so it wasn't visible. It should be unblocked now. Regarding this commit I'll update it to the current main branch at some point if feature still needed (haven't looked to see if you've done this already!)

@marc3linho
Copy link
Owner

Thanks for your PR, unfortunately I have only just been able to see it because of your 'shadow block'.
A function as described by you has not yet been implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants