feat: WM Release Nov 2025 by 0xfarhaan · Pull Request #2 · maple-labs/withdrawal-manager-queue

0xfarhaan · 2025-11-27T13:04:50Z

No description provided.

* Update README.md new logo * fix: fixed ci versions

* feat: update shares, refactor, basic test Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: avoid trailing zero array entries Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting and shortcut return if zero array Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: added some unit tests, batch updateShares and fixes. Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: updated tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: removed commented code Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: removed console logs Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: pr review changes Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: pr feedback Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: updated tests, added requestsCountByUser mapping Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: max iteration check Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: removed gas limit test as it broke the gas report Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * Feat: Depreciate request ids mapping (Sc-20631) (#31) * feat: updated tests to depreciate requestIds mapping (WIP) Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: fixed tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: fixed returning wrong array elements Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: pr review fixes Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: pr review fixes Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: updated tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: naming conventions Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: Add TODOs and formatting * chore: Add TODOs and formatting * feat: refactored the view functions Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: renamed storage Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: added tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: cleanup * chore: cleanup --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

* feat: fixed todo's Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: added multiple remove tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat:reordered some functions Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: fix formatting --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

* feat: added userRequestSummaries Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: missing share changes Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: missing natspec Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: added tests for userRequestSummaries Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: comments Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

* fix: keep track of withdraw requests per user * feat: keep only active redeem requests in userRequests array * fix: update failing tests and fix indexes * fix: bring back console import * chore: import style * chore: library format * feat: upgrade removeRequest test for more complex scenario * fix: remove userRequestSummaries and bring back userRequests function * chore: rename mapping * fix: remove isPresent mapping * fix: renamings * feat: unit tests for library * fix: remove empty lines at the end of the files * Revert "fix: remove empty lines at the end of the files" This reverts commit 312e3207f9b6a17a8944d9540dc2273156bd9968. * chore: format * chore: formatting * fix: add extra require statements * feat: add invalid range test * fix: rename removeByValue to remove * fix: remove padination request getter * chore: Fix formatting, return value and test ordering * chore: Add TODO --------- Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

…57) (#35) * feat: update removeShares to iterate over all user's requests * chore: format * chore: remove unnecessary return statement * fix: update push tests for SortedArray library * chore: formatting --------- Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

* feat: added migrator * feat: added unit tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: unit tests and migrator Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: fixed storage layout bug Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: rename and formatting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * chore: removed file Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * fix: fix test Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com>

* feat: changed wm interfaces to use uint256 Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: more casting Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * pr fixes Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com>

* feat: Add removeSharesById Functionality * fix: err messages + test cases * feat: Add additional require * chore: format * fix: test cases * feat: Update Interface and Tests * feat: Update Test with multiple LPs * chore: fix formatting * chore: fix stack too deep * chore: fix test name * chore: update impl * chore: address PR comments * chore: fix events

* feat: changed access control Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> * feat: added tests Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com> --------- Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com>

* feat: update event per OC request * feat: Internal audit fixes * feat: fix foundry TOML * fix: comment out fuzz tests * fix: comment out fuzz tests * fix: comment out fuzz tests * fix: Alignment

* Audit: Add comment clarifying usage for removeRequest on WM * chore: add comment

* fix: add bot support for removeRequests() * chore: Fix format --------- Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

* feat: Swap Array to LinkedList * feat: update sorted linked list * fix: rename array to list * fix: remove get function from library * fix: cache list size * chore: format: * fix: remove unneccesary casting --------- Co-authored-by: Danilo <kitanovic.danilo@outlook.com>

* feat: Interal audit fixes * feat: ASCII Art

Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com>

* audit: Fix DOS Issue * chore: order event * chore: order functions * fix: PR comments * fix: PR comments * fix: code comment

sherlock-ai-github-agent · 2025-11-27T13:04:55Z

Sherlock AI

Thank you for using Sherlock AI!

**Security Review Unavailable**: Your account doesn't have an active subscription.     To enable automated security reviews on your pull requests, please visit     [https://ai.sherlock.xyz](https://ai.sherlock.xyz) to set up your subscription.

Once activated, Sherlock AI will automatically analyze your code changes and provide     detailed security findings directly in your pull requests.

Need help? Reach out to us at [contact@sherlock.xyz](mailto:contact@sherlock.xyz).

github-actions · 2025-11-27T13:05:23Z

| contracts/MapleWithdrawalManager.sol:MapleWithdrawalManager Contract |                 |       |        |       |         |
| Deployment Cost                                                      | Deployment Size |       |        |       |         |
|----------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| 5939678                                                              | 27423           |       |        |       |         |
|----------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                                      |                 |       |        |       |         |
|----------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                                        | Min             | Avg   | Median | Max   | # Calls |
|----------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| implementation                                                       | 621             | 621   | 621    | 621   | 2       |
|----------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| migrate                                                              | 7692            | 11527 | 12806  | 12806 | 4       |
| contracts/proxy/MapleWithdrawalManagerFactory.sol:MapleWithdrawalManagerFactory Contract |                 |        |        |        |         |
| Deployment Cost                                                                          | Deployment Size |        |        |        |         |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| 2980005                                                                                  | 14164           |        |        |        |         |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
|                                                                                          |                 |        |        |        |         |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| Function Name                                                                            | Min             | Avg    | Median | Max    | # Calls |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| createInstance                                                                           | 31232           | 305462 | 310799 | 310799 | 122     |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| defaultImplementation                                                                    | 4789            | 4789   | 4789   | 4789   | 121     |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| enableUpgradePath                                                                        | 79919           | 79919  | 79919  | 79919  | 6       |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| mapleGlobals                                                                             | 537             | 1511   | 537    | 2537   | 3264    |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| registerImplementation                                                                   | 105470          | 105481 | 105482 | 105482 | 127     |
|------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| setDefaultVersion                                                                        | 55077           | 55077  | 55077  | 55077  | 121     |
| contracts/proxy/MapleWithdrawalManagerInitializer.sol:MapleWithdrawalManagerInitializer Contract |                 |        |        |        |         |
| Deployment Cost                                                                                  | Deployment Size |        |        |        |         |
|--------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| 692777                                                                                           | 3003            |        |        |        |         |
|--------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
|                                                                                                  |                 |        |        |        |         |
|--------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| Function Name                                                                                    | Min             | Avg    | Median | Max    | # Calls |
|--------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| fallback                                                                                         | 841             | 109050 | 111501 | 111501 | 121     |
| contracts/proxy/MapleWithdrawalManagerMigratorV200.sol:MapleWithdrawalManagerMigratorV200 Contract |                 |        |        |        |         |
| Deployment Cost                                                                                    | Deployment Size |        |        |        |         |
|----------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| 749295                                                                                             | 3266            |        |        |        |         |
|----------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
|                                                                                                    |                 |        |        |        |         |
|----------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| Function Name                                                                                      | Min             | Avg    | Median | Max    | # Calls |
|----------------------------------------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| fallback                                                                                           | 377080          | 377080 | 377080 | 377080 | 1       |
| modules/erc20/contracts/test/mocks/MockERC20.sol:MockERC20 Contract |                 |       |        |       |         |
| Deployment Cost                                                     | Deployment Size |       |        |       |         |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| 1398621                                                             | 7253            |       |        |       |         |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                                     |                 |       |        |       |         |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                                       | Min             | Avg   | Median | Max   | # Calls |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| balanceOf                                                           | 859             | 1784  | 859    | 2859  | 605     |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| burn                                                                | 27700           | 33458 | 34625  | 34625 | 6       |
|---------------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| mint                                                                | 34632           | 66694 | 68832  | 68832 | 32      |
| modules/maple-proxy-factory/modules/proxy-factory/contracts/Proxy.sol:Proxy Contract |                 |       |        |        |         |
| Deployment Cost                                                                      | Deployment Size |       |        |        |         |
|--------------------------------------------------------------------------------------+-----------------+-------+--------+--------+---------|
| 0                                                                                    | 940             |       |        |        |         |
|--------------------------------------------------------------------------------------+-----------------+-------+--------+--------+---------|
|                                                                                      |                 |       |        |        |         |
|--------------------------------------------------------------------------------------+-----------------+-------+--------+--------+---------|
| Function Name                                                                        | Min             | Avg   | Median | Max    | # Calls |
|--------------------------------------------------------------------------------------+-----------------+-------+--------+--------+---------|
| fallback                                                                             | 1178            | 57864 | 11147  | 419536 | 26355   |
| tests/utils/Harnesses.sol:MapleWithdrawalManagerHarness Contract |                 |        |        |        |         |
| Deployment Cost                                                  | Deployment Size |        |        |        |         |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| 6405670                                                          | 29581           |        |        |        |         |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
|                                                                  |                 |        |        |        |         |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| Function Name                                                    | Min             | Avg    | Median | Max    | # Calls |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setLastRequest                                                 | 84412           | 84412  | 84412  | 84412  | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setManualSharesAvailable                                       | 3065            | 22512  | 22965  | 22965  | 264     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setManualWithdrawal                                            | 22958           | 22958  | 22958  | 22958  | 16      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setQueue                                                       | 3371            | 3721   | 3371   | 6171   | 16      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setRequest                                                     | 81473           | 120098 | 121273 | 128969 | 35      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setRequestLegacy                                               | 55603           | 68428  | 72703  | 72703  | 4       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setTotalShares                                                 | 22588           | 22588  | 22588  | 22588  | 21      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| __setUserRequestCount                                            | 25455           | 25455  | 25455  | 25455  | 27      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| addShares                                                        | 3219            | 186073 | 181418 | 215618 | 5663    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| asset                                                            | 8372            | 8372   | 8372   | 8372   | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| factory                                                          | 2643            | 2643   | 2643   | 2643   | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| globals                                                          | 8395            | 8395   | 8395   | 8395   | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| governor                                                         | 14094           | 14094  | 14094  | 14094  | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| implementation                                                   | 688             | 688    | 688    | 688    | 131     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| isInExitWindow                                                   | 703             | 703    | 703    | 703    | 256     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| isManualWithdrawal                                               | 2979            | 2979   | 2979   | 2979   | 5       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| locked                                                           | 2548            | 2548   | 2548   | 2548   | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| lockedLiquidity                                                  | 441             | 441    | 441    | 441    | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| lockedShares                                                     | 2973            | 2973   | 2973   | 2973   | 256     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| manualSharesAvailable                                            | 2925            | 2925   | 2925   | 2925   | 163     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| migrate                                                          | 8472            | 113799 | 118764 | 392837 | 128     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| pool                                                             | 2605            | 2605   | 2605   | 2605   | 3       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| poolManager                                                      | 2602            | 2602   | 2602   | 2602   | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| previewRedeem                                                    | 3261            | 18083  | 17990  | 33094  | 4       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| previewWithdraw                                                  | 989             | 989    | 989    | 989    | 256     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| processEmptyRedemptions                                          | 14965           | 27575  | 27581  | 33007  | 16      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| processExit                                                      | 3244            | 34138  | 29560  | 73069  | 10      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| processRedemptions                                               | 14875           | 111784 | 107292 | 327424 | 276     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| queue                                                            | 2899            | 2899   | 2899   | 2899   | 3827    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| removeRequest                                                    | 15159           | 68113  | 81697  | 109539 | 8       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| removeShares                                                     | 3199            | 32855  | 5449   | 151491 | 489     |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| removeSharesById                                                 | 15075           | 71515  | 90435  | 107535 | 30      |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| requestIds                                                       | 3072            | 3072   | 3072   | 3072   | 2       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| requests                                                         | 5441            | 5441   | 5441   | 5441   | 3344    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| requestsByOwner                                                  | 6142            | 9184   | 11971  | 23318  | 6360    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| securityAdmin                                                    | 14137           | 14137  | 14137  | 14137  | 1       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| setImplementation                                                | 6872            | 10418  | 6872   | 15372  | 7       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| setManualWithdrawal                                              | 15122           | 48000  | 48060  | 48060  | 1240    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| totalShares                                                      | 2519            | 2519   | 2519   | 2519   | 3549    |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| upgrade                                                          | 15176           | 48529  | 48975  | 75113  | 8       |
|------------------------------------------------------------------+-----------------+--------+--------+--------+---------|
| userEscrowedShares                                               | 2904            | 2904   | 2904   | 2904   | 55      |
| tests/utils/Harnesses.sol:SortedLinkedListHarness Contract |                 |       |        |       |         |
| Deployment Cost                                            | Deployment Size |       |        |       |         |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| 863302                                                     | 3801            |       |        |       |         |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                            |                 |       |        |       |         |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                              | Min             | Avg   | Median | Max   | # Calls |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| getAllValues                                               | 5165            | 8451  | 8004   | 13578 | 6       |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| length                                                     | 2464            | 2464  | 2464   | 2464  | 12      |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| push                                                       | 24188           | 76625 | 92231  | 99927 | 13      |
|------------------------------------------------------------+-----------------+-------+--------+-------+---------|
| remove                                                     | 24227           | 33483 | 32662  | 39039 | 5       |
| tests/utils/Mocks.sol:MockFactory Contract |                 |       |        |       |         |
| Deployment Cost                            | Deployment Size |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| 167137                                     | 560             |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
|                                            |                 |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                              | Min             | Avg   | Median | Max   | # Calls |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setIsInstance                            | 21871           | 43595 | 43783  | 43783 | 117     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| isInstance                                 | 2771            | 2771  | 2771   | 2771  | 119     |
| tests/utils/Mocks.sol:MockGlobals Contract |                 |       |        |       |         |
| Deployment Cost                            | Deployment Size |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| 563913                                     | 2555            |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
|                                            |                 |       |        |       |         |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                              | Min             | Avg   | Median | Max   | # Calls |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setCanDeploy                             | 23956           | 42768 | 43856  | 43856 | 123     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setFunctionPaused                        | 26778           | 26778 | 26778  | 26778 | 9       |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setIsInstanceOf                          | 24022           | 26800 | 26822  | 26822 | 140     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setIsValidScheduledCall                  | 26801           | 26801 | 26801  | 26801 | 3       |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setOperationalAdmin                      | 44120           | 44120 | 44120  | 44120 | 116     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| __setSecurityAdmin                         | 27021           | 27021 | 27021  | 27021 | 116     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| canDeploy                                  | 2888            | 2888  | 2888   | 2888  | 122     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| governor                                   | 2557            | 2557  | 2557   | 2557  | 376     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| isFunctionPaused                           | 889             | 2738  | 2889   | 2889  | 1717    |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| isInstanceOf                               | 1039            | 1039  | 1039   | 1039  | 417     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| isValidScheduledCall                       | 1567            | 1567  | 1567   | 1567  | 4       |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| operationalAdmin                           | 2538            | 2538  | 2538   | 2538  | 7       |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| protocolPaused                             | 588             | 588   | 588    | 588   | 125     |
|--------------------------------------------+-----------------+-------+--------+-------+---------|
| securityAdmin                              | 558             | 1058  | 558    | 2558  | 4       |
| tests/utils/Mocks.sol:MockPool Contract |                 |       |        |       |         |
| Deployment Cost                         | Deployment Size |       |        |       |         |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| 1594452                                 | 8181            |       |        |       |         |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
|                                         |                 |       |        |       |         |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                           | Min             | Avg   | Median | Max   | # Calls |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| __setPoolManager                        | 44166           | 44166 | 44166  | 44166 | 116     |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| approve                                 | 46728           | 46789 | 46800  | 46872 | 5645    |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| asset                                   | 611             | 1538  | 611    | 2611  | 606     |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| balanceOf                               | 2881            | 2881  | 2881   | 2881  | 12      |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| burn                                    | 29753           | 30953 | 29753  | 34553 | 4       |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| manager                                 | 2559            | 2559  | 2559   | 2559  | 120     |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| mint                                    | 34572           | 54251 | 51744  | 68904 | 5678    |
|-----------------------------------------+-----------------+-------+--------+-------+---------|
| totalSupply                             | 497             | 1422  | 497    | 2497  | 605     |
| tests/utils/Mocks.sol:MockPoolManager Contract |                 |       |        |       |         |
| Deployment Cost                                | Deployment Size |       |        |       |         |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| 343353                                         | 1543            |       |        |       |         |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
|                                                |                 |       |        |       |         |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| Function Name                                  | Min             | Avg   | Median | Max   | # Calls |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| __setFactory                                   | 44054           | 44054 | 44054  | 44054 | 116     |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| __setTotalAssets                               | 43841           | 43841 | 43841  | 43841 | 30      |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| factory                                        | 2577            | 2577  | 2577   | 2577  | 120     |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| poolDelegate                                   | 2581            | 2581  | 2581   | 2581  | 1264    |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| totalAssets                                    | 430             | 1355  | 430    | 2430  | 605     |
|------------------------------------------------+-----------------+-------+--------+-------+---------|
| unrealizedLosses                               | 451             | 1376  | 451    | 2451  | 605     |
| tests/utils/Mocks.sol:MockWithdrawalManagerMigrator Contract |                 |      |        |      |         |
| Deployment Cost                                              | Deployment Size |      |        |      |         |
|--------------------------------------------------------------+-----------------+------+--------+------+---------|
| 323002                                                       | 1282            |      |        |      |         |
|--------------------------------------------------------------+-----------------+------+--------+------+---------|
|                                                              |                 |      |        |      |         |
|--------------------------------------------------------------+-----------------+------+--------+------+---------|
| Function Name                                                | Min             | Avg  | Median | Max  | # Calls |
|--------------------------------------------------------------+-----------------+------+--------+------+---------|
| fallback                                                     | 155             | 3747 | 5543   | 5543 | 6       |

github-actions · 2025-11-27T13:05:42Z

LCOV of commit `e111405` during CI #4

Summary coverage rate:
  lines......: 98.8% (253 of 256 lines)
  functions..: 98.0% (48 of 49 functions)
  branches...: 96.0% (95 of 99 branches)

Files changed coverage rate:
                                                        |Lines       |Functions  |Branches    
  Filename                                              |Rate     Num|Rate    Num|Rate     Num
  ============================================================================================
  contracts/MapleWithdrawalManager.sol                  |20.4%    191| 203%    38|    -      0
  contracts/proxy/MapleWithdrawalManagerMigratorV200.sol|12.5%      8| 0.0%     1|    -      0
  contracts/utils/SortedLinkedList.sol                  |16.7%     36| 233%     6|    -      0

calmacfadden and others added 21 commits May 23, 2025 16:14

Update README.md new logo (#28)

4f63ee4

* Update README.md new logo * fix: fixed ci versions

chore: update format (#39)

cd8f632

feat: Internal Audit fixes (#42)

d272590

* feat: update event per OC request * feat: Internal audit fixes * feat: fix foundry TOML * fix: comment out fuzz tests * fix: comment out fuzz tests * fix: comment out fuzz tests * fix: Alignment

feat: Use external over public (#44)

31481c1

Audit: Fix for loop usage for removing shares via admin (#45)

2738521

Audit: Add comment clarifying usage for removeRequest on WM (#46)

335ea60

* Audit: Add comment clarifying usage for removeRequest on WM * chore: add comment

fix: Add bot support for removeRequest() (SC-22023) (#47)

74cf0c3

* fix: add bot support for removeRequests() * chore: Fix format --------- Co-authored-by: 0xfarhaan <59924029+0xfarhaan@users.noreply.github.com>

feat: Internal audit fixes (#48)

316aa79

* feat: Interal audit fixes * feat: ASCII Art

feat: added unit tests (#50)

2536a8a

Signed-off-by: calmacfadden <cathalmf+calmacfadden@gmail.com>

audit: Fix DOS Issue due to large number of empty requests (#49)

76a8ba7

* audit: Fix DOS Issue * chore: order event * chore: order functions * fix: PR comments * fix: PR comments * fix: code comment

chore: Update README

e111405

0xfarhaan self-assigned this Nov 27, 2025

0xfarhaan requested a review from a team as a code owner November 27, 2025 13:04

0xfarhaan merged commit 2382e40 into main Nov 27, 2025
4 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Comments

feat: WM Release Nov 2025#2

feat: WM Release Nov 2025#2
0xfarhaan merged 21 commits intomainfrom
releaseBranch-wm-2025

0xfarhaan commented Nov 27, 2025

Uh oh!

sherlock-ai-github-agent bot commented Nov 27, 2025

Uh oh!

github-actions bot commented Nov 27, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 27, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Comments

Conversation

0xfarhaan commented Nov 27, 2025

Uh oh!

sherlock-ai-github-agent bot commented Nov 27, 2025

Sherlock AI

Uh oh!

github-actions bot commented Nov 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Nov 27, 2025

LCOV of commit e111405 during CI #4

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

github-actions bot commented Nov 27, 2025 •

edited

Loading

LCOV of commit `e111405` during CI #4