Deck gl package upgrade #252
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
December 12, 2025 10:40
…gonLayer import path
…or custom color and hight profile
…Layer and MlScenegraphLayer components
Moving Deckglcontext in MapContextDecorator.tsx
cioddi
requested changes
Jan 14, 2026
| tile3dLayer && deckGlHook.removeLayer(tile3dLayer); | ||
| initializedRef.current = false; | ||
| }; | ||
| }, [mapHook.map]); |
Member
There was a problem hiding this comment.
tile3dLayer is missing in the dependency array. This will prevent the Layer from being updated if props change.
| const mapHook = useMap({ mapId: mapId }); | ||
| const deckGlHook = useDeckGl(); | ||
|
|
||
| const initializedRef = useRef(false); |
Member
There was a problem hiding this comment.
initializedRef can be removed. In general this (initializedRef) pattern should be avoided if possible.
| ]); | ||
|
|
||
| useEffect(() => { | ||
| if (!mapHook.map || initializedRef.current) return; |
| waitForLayer: HexagonLayerProps.beforeId, | ||
| }); | ||
|
|
||
| const initializedRef = useRef(false); |
| data: station_features, | ||
| getPosition: (d: any) => d.geometry.coordinates, | ||
| getOrientation: (d: any) => [0, d.properties.rotation, 90], | ||
| scenegraph: '/assets/3D/train.glb', |
Member
There was a problem hiding this comment.
We need attribution (author, source, license) for the 3D models in the storybook demo.
| } | ||
|
|
||
| const MlScenegraphLayer = (props: MlScenegraphLayerProps) => { | ||
| const initializedRef = useRef(false); |
| scenegraphLayer && deckGlHook.removeLayer(scenegraphLayer); | ||
| initializedRef.current = false; | ||
| }; | ||
| }, [mapHook.map]); |
Member
There was a problem hiding this comment.
scenegraphLayer is missing in the dependency array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.