Restore JSDoc change to the Camera section of Map Instance Members#13621
Closed
chriswhong wants to merge 1 commit intomainfrom
Closed
Restore JSDoc change to the Camera section of Map Instance Members#13621chriswhong wants to merge 1 commit intomainfrom
chriswhong wants to merge 1 commit intomainfrom
Conversation
|
Hey, @chriswhong 👋 Thanks for your contribution to Mapbox GL JS! Important: This repository does not accept direct merges. All changes go through our internal review process. What happens next:
Please respond to any review comments on this PR. For more details, see CONTRIBUTING.md. |
mourner
approved these changes
Feb 4, 2026
Member
|
Please submit the PR in the internal repo to get this merged 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR reverts a JSDoc change made in #13439 that caused a rendering issue with the API reference documentation on docs.mapbox.com.
The change caused
documentation.jsto omit the sub-sectionCameraunder instance members, causing all of the camera members (flyTo(),getZoom(), etc) to be listed under the preceding sectionDebug features.Restoring the JSDoc comment causes
documentation.jsto properly add theCamerasection to its output, and the docs site will render it correctly.Launch Checklist
@mapbox/map-design-team@mapbox/static-apisif this PR includes style spec API or visual changes.@mapbox/gl-nativeif this PR includes shader changes or needs a native port.@mapbox/gl-nativeif this PR disables any test because it also needs to be disabled on their side.gl-nativeto groom in the MAPSNAT JIRA queue if this PR includes shader changes or features not present in the native side or if it disables a test that's not disabled there.