Skip to content

Comments

Handle background fetch errors non-blockingly with toolbar warning#197

Merged
maoyama merged 1 commit intomaoyama:mainfrom
nniel-ape:non-blocking-sync-error
Feb 22, 2026
Merged

Handle background fetch errors non-blockingly with toolbar warning#197
maoyama merged 1 commit intomaoyama:mainfrom
nniel-ape:non-blocking-sync-error

Conversation

@nniel-ape
Copy link
Contributor

@nniel-ape nniel-ape commented Feb 16, 2026 •
edited
Loading

Summary

  • Make SyncState.sync() non-throwing so background fetch failures no longer surface disruptive error alerts to the user
  • Capture errors in a new syncError property and log them via os.Logger
  • Show a yellow warning triangle in the toolbar with a popover displaying the error message when sync fails

Test plan

  • All 34 existing tests pass (5 SyncStateTests updated to remove try)
  • Verify warning triangle appears when network is unavailable
  • Verify popover shows the error message on click
  • Verify the triangle disappears after a successful sync

@nniel-ape
Handle background fetch errors non-blockingly with toolbar warning
4b9cf35 
Make SyncState.sync() non-throwing so background fetch failures no
longer surface disruptive error alerts. Errors are captured in a new
syncError property and logged via os.Logger. FolderView shows a yellow
warning triangle in the toolbar with a popover containing the error
message when a sync error occurs.
@maoyama
Copy link
Owner

maoyama commented Feb 22, 2026

Thank you for your PR!
The UI you implemented is better than alerts 👍

@maoyama maoyama merged commit b30973f into maoyama:main Feb 22, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@nniel-ape @maoyama