Skip to content

Feat: Add exceptions support in table creation #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KlimTodrik merged 1 commit into from
May 12, 2025
Merged

Feat: Add exceptions support in table creation #10

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/PHPSQLParser/processors/TableProcessor.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,6 +231,7 @@ public function process($tokens)
case 'AUTO_INCREMENT':
case 'AVG_ROW_LENGTH':
case 'ENGINE':
case 'EXCEPTIONS':
case 'TYPE':
case 'STATS_AUTO_RECALC':
case 'STATS_PERSISTENT':
Expand Down
3 changes: 2 additions & 1 deletion tests/cases/parser/manticoreCasesTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ protected function setup(): void
public function manticoreCasesTest($query, $resultFileName)
{
$p = $this->parser->parse($query);
// setExpectedValue(dirname(__FILE__), $resultFileName . '.serialized', $p);
setExpectedValue(dirname(__FILE__), $resultFileName . '.serialized', $p);
$expected = getExpectedValue(dirname(__FILE__), $resultFileName . '.serialized');
$this->assertEquals($expected, $p);
}
Expand Down Expand Up @@ -96,6 +96,7 @@ public function manticoreQueryProvider(): array
["CREATE TABLE destination_kafka (id bigint, name text, short_name text, received_at text, size multi) engine='columnar'", 'ms_create_table_1'],
["CREATE TABLE new_table LIKE existing_table WITH DATA", 'ms_create_table_2'],
["CREATE TABLE new_table LIKE comment WITH DATA", 'ms_create_table_3'],
["CREATE TABLE new_table (id bigint, name text) engine='columnar' exceptions='wordnet-english'", 'ms_create_table_4'],
["SHOW TABLES", 'ms_show_tables_1'],
["SHOW TABLE abc", 'ms_show_tables_2'],
["SHOW TABLE `abc`", 'ms_show_tables_3'],
Expand Down
1 change: 1 addition & 0 deletions tests/expected/parser/ms_create_table_4.serialized
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
a:2:{s:6:"CREATE";a:4:{s:9:"expr_type";s:5:"table";s:10:"not-exists";b:0;s:9:"base_expr";s:5:"TABLE";s:8:"sub_tree";a:1:{i:0;a:2:{s:9:"expr_type";s:8:"reserved";s:9:"base_expr";s:5:"TABLE";}}}s:5:"TABLE";a:5:{s:9:"base_expr";s:9:"new_table";s:4:"name";s:9:"new_table";s:9:"no_quotes";a:2:{s:5:"delim";b:0;s:5:"parts";a:1:{i:0;s:9:"new_table";}}s:10:"create-def";a:3:{s:9:"expr_type";s:18:"bracket_expression";s:9:"base_expr";s:23:" (id bigint, name text)";s:8:"sub_tree";a:2:{i:0;a:3:{s:9:"expr_type";s:10:"column-def";s:9:"base_expr";s:9:"id bigint";s:8:"sub_tree";a:2:{i:0;a:3:{s:9:"expr_type";s:6:"colref";s:9:"base_expr";s:2:"id";s:9:"no_quotes";a:2:{s:5:"delim";b:0;s:5:"parts";a:1:{i:0;s:2:"id";}}}i:1;a:7:{s:9:"expr_type";s:11:"column-type";s:9:"base_expr";s:6:"bigint";s:8:"sub_tree";a:1:{i:0;a:5:{s:9:"expr_type";s:9:"data-type";s:9:"base_expr";s:6:"bigint";s:8:"unsigned";b:0;s:8:"zerofill";b:0;s:6:"length";b:0;}}s:6:"unique";b:0;s:8:"nullable";b:1;s:8:"auto_inc";b:0;s:7:"primary";b:0;}}}i:1;a:3:{s:9:"expr_type";s:10:"column-def";s:9:"base_expr";s:9:"name text";s:8:"sub_tree";a:2:{i:0;a:3:{s:9:"expr_type";s:6:"colref";s:9:"base_expr";s:4:"name";s:9:"no_quotes";a:2:{s:5:"delim";b:0;s:5:"parts";a:1:{i:0;s:4:"name";}}}i:1;a:7:{s:9:"expr_type";s:11:"column-type";s:9:"base_expr";s:4:"text";s:8:"sub_tree";a:1:{i:0;a:3:{s:9:"expr_type";s:9:"data-type";s:9:"base_expr";s:4:"text";s:6:"binary";b:0;}}s:6:"unique";b:0;s:8:"nullable";b:1;s:8:"auto_inc";b:0;s:7:"primary";b:0;}}}}}s:7:"options";a:2:{i:0;a:4:{s:9:"expr_type";s:10:"expression";s:9:"base_expr";s:17:"engine='columnar'";s:5:"delim";s:1:" ";s:8:"sub_tree";a:3:{i:0;a:2:{s:9:"expr_type";s:8:"reserved";s:9:"base_expr";s:6:"engine";}i:1;a:2:{s:9:"expr_type";s:8:"operator";s:9:"base_expr";s:1:"=";}i:2;a:2:{s:9:"expr_type";s:5:"const";s:9:"base_expr";s:10:"'columnar'";}}}i:1;a:4:{s:9:"expr_type";s:10:"expression";s:9:"base_expr";s:28:"exceptions='wordnet-english'";s:5:"delim";s:1:" ";s:8:"sub_tree";a:3:{i:0;a:2:{s:9:"expr_type";s:8:"reserved";s:9:"base_expr";s:10:"exceptions";}i:1;a:2:{s:9:"expr_type";s:8:"operator";s:9:"base_expr";s:1:"=";}i:2;a:2:{s:9:"expr_type";s:5:"const";s:9:"base_expr";s:17:"'wordnet-english'";}}}}}}
Loading