Fix race condition in session key authentication #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When realmName is set in WTF/Config.wtf, clients connect to mangosd before realmd's async PExecute completes, causing authentication failures with mismatched session keys. Explanation: PExecute is asynchronous and doesn't guarantee the write is visible to other database connections immediately. When the client switch to the main mangosd server is quick enough, mangosd will still see the old sessionKey value in the account table, causing auth to fail. Fix: Replace PExecute with synchronous Execute using explicit transaction control, and add verification loop to confirm session key is written and visible before sending authentication acknowledgement to client. I personally verified that this fix allows consistent login with realmName set, which was previously consistently failing (forcing me to remove that line from WTF/Config.wtf to even login).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When realmName is set in WTF/Config.wtf, clients connect to mangosd before realmd's async PExecute completes, causing authentication failures with mismatched session keys.
Explanation:
PExecute is asynchronous and doesn't guarantee the write is visible to other database connections immediately. When the client switch to the main mangosd server is quick enough, mangosd will still see the old sessionKey value in the account table, causing auth to fail.
Fix:
Replace PExecute with synchronous Execute using explicit transaction control, and add verification loop to confirm session key is written and visible before sending authentication acknowledgement to client. I personally verified that this fix allows consistent login with realmName set, which was previously consistently failing (forcing me to remove that line from WTF/Config.wtf to even login).
This change is