-
Notifications
You must be signed in to change notification settings - Fork 2
Add repository agent guidelines #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add repository agent guidelines #4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR upgrades the Orleans.RateLimiting library from .NET 8 to .NET 9, updating all dependencies to their latest versions and modernizing the CI/CD pipeline.
- Migrates all projects to target .NET 9.0
- Updates Orleans dependencies from 8.1.0 to 9.2.1
- Replaces FluentAssertions test library with Shouldly
- Modernizes GitHub Actions workflows with new CI, CodeQL, and Release pipelines
Reviewed Changes
Copilot reviewed 20 out of 20 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| README.md | Updates documentation to reflect .NET 9 targeting, fixes spelling errors (Attributes, middleware), adds build instructions and CI badges |
| ManagedCode.Orleans.RateLimiting.Tests/ManagedCode.Orleans.RateLimiting.Tests.csproj | Migrates to .NET 9.0 and updates all test dependencies including Orleans 9.2.1, ASP.NET Core 9.0.10, xunit 2.9.3/3.1.5, and adds Shouldly 4.2.1 |
| ManagedCode.Orleans.RateLimiting.Tests/*.cs | Replaces FluentAssertions syntax with Shouldly assertions across all test files |
| ManagedCode.Orleans.RateLimiting.Server/ManagedCode.Orleans.RateLimiting.Server.csproj | Updates to .NET 9.0 and Orleans 9.2.1 dependencies |
| ManagedCode.Orleans.RateLimiting.Core/ManagedCode.Orleans.RateLimiting.Core.csproj | Updates to .NET 9.0 and Orleans 9.2.1 dependencies |
| ManagedCode.Orleans.RateLimiting.Client/ManagedCode.Orleans.RateLimiting.Client.csproj | Updates to .NET 9.0, Orleans 9.2.1, and ManagedCode.Communication 9.6.5 |
| ManagedCode.Orleans.RateLimiting.Client/Middlewares/OrleansBaseRateLimitingMiddleware.cs | Corrects Result.Fail parameter order to match updated ManagedCode.Communication 9.6.5 API |
| Directory.Build.props | Bumps package version from 0.0.8 to 0.0.9 and updates DotNet.ReproducibleBuilds to 1.2.39 |
| AGENTS.md | Adds new agent guidelines document for development standards |
| .github/workflows/release.yml | Adds comprehensive new release workflow with NuGet publishing and GitHub release automation |
| .github/workflows/ci.yml | Adds new CI workflow replacing the old dotnet.yml workflow |
| .github/workflows/codeql-analysis.yml | Modernizes CodeQL workflow with updated actions and .NET 9 support |
| .github/workflows/nuget.yml | Removes old NuGet workflow (replaced by release.yml) |
| .github/workflows/dotnet.yml | Removes old .NET workflow (replaced by ci.yml) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| <PackageReference Include="xunit" Version="2.9.3" /> | ||
| <PackageReference Include="xunit.runner.visualstudio" Version="3.1.5"> | ||
| <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets> | ||
| <PrivateAssets>all</PrivateAssets> | ||
| </PackageReference> | ||
| <PackageReference Include="xunit.runner.console" Version="2.8.0"> | ||
| <PackageReference Include="xunit.runner.console" Version="2.9.3"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align xUnit runner with xUnit package version
The test project still references xunit 2.9.3 while xunit.runner.visualstudio was bumped to 3.1.5. The 3.x Visual Studio runner is designed for xUnit.net v3 and is not compatible with v2 test assemblies, which means test discovery/execution in CI or Visual Studio will fail or skip all tests. Either revert the runner back to the latest 2.x release or upgrade the whole test suite to xUnit v3 so the tooling versions match.
Useful? React with 👍 / 👎.
Summary
Testing
Codex Task