Open
Conversation
added 2 commits
October 6, 2021 14:23
|
This pull request has been linked to Shortcut Story #69590: Consul-Srv refactor of resolver class as a POC. |
ChrisStatham
approved these changes
Nov 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
The following features/changes were introduce:
How can I test it?
Get the
mksp-composerepo, and set up the services:Checkout this branch
Build the image:
Run the image. You get logged in into a Python 3 shell.
Run the following commands to install dependencies and prepare to run the consul_srv:
python setup.py bdist_wheel --universal pip install . pythonYou can now check the DNS request returned the right data by running this commands:
You should get an output like
'https://35.169.11.217:443/status/data.json'.Any relevant Ticket?
🎫 Consul Srv refactor of resolver class as [sc-69590]
Any extra or background information?