Skip to content

Conversation

@Real-Septicake
Copy link
Collaborator

Description

Function command parameter function now takes an integer parameter, which the command index is passed into, for logging purposes. A test to make sure that a loop can run exactly once, like do { ... } while(false), was also added. Also doing this to make sure that we can actually do commit merges.

Issue #

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Testing

Please describe tests that you ran to verify your changes. Provide instructions so that we can reproduce. Please also list any relevant details for your test configuration.

Test Configuration:

  • Hardware: 82RK IdeaPad 3 15IAU7 with 12th Gen Intel i5-1235U CPU
  • OS: Linux Mint 21.3 x86_64

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Real-Septicake Real-Septicake merged commit 68bd57d into makeopensource:main Feb 15, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants