Skip to content

Conversation

@Real-Septicake
Copy link
Collaborator

Description

Added kb_cmd.h and its test files

Issue #

Type of change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)

Testing

I wrote test_kb_cmd.h

Test Configuration:

  • Hardware: Qemu 6.2.0 on Linux Mint 21.3 x86_64
  • OS: Linux Mint (bookworm/sid virginia) 21.3 x86_64

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Copy link
Member

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a few things that need to be addressed
(Also probably avoid explicit profanity 😉)

Copy link
Member

@Sploder12 Sploder12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work! 1 missed static and this should be good to go!

@Sploder12 Sploder12 merged commit b05da87 into makeopensource:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants