Skip to content

Improving Imports #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
emilkovacev wants to merge 2 commits into
base: v2.0
Choose a base branch
from
Open

Improving Imports #95

emilkovacev wants to merge 2 commits into from

Conversation

@emilkovacev
Copy link
Member

@emilkovacev emilkovacev commented Nov 9, 2022

Proposed changes

Instead of relying on the sys library to attempt to make relative imports, this PR formats imports with a more standard approach, which hopefully should work seamlessly on other systems.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • My changeset covers only what is described above (no extraneous changes)
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged downstream

@emilkovacev emilkovacev added the enhancement New feature or request label Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement New feature or request

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@emilkovacev