UV-278 - Modbus Adapter #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
rodneyosodo
suggested changes
Sep 8, 2023
arvindh123
reviewed
Sep 14, 2023
Refactor the modbus adapter codebase by removing unnecessary imports and unused constants. Signed-off-by: SammyOina <sammyoina@gmail.com>
The Makefile test command was modified to remove the "-mod=vendor" flag and the proto generation commands were removed as they are unnecessary. This commit fixes the Makefile test command and removes unnecessary proto generation commands. Signed-off-by: SammyOina <sammyoina@gmail.com>
rodneyosodo
suggested changes
Sep 21, 2023
The logger output in the modbus service was not being properly formatted. This commit fixes the issue by using the logger.Info function to print the modbus service listening information. - Update logger output in modbus service to use logger.Info function - Fix formatting issue with logger output in modbus service Signed-off-by: SammyOina <sammyoina@gmail.com>
This commit fixes bugs related to subscription and publishing in the examples/publish/main.go and examples/subscribe/main.go files. The changes include adding the context package and passing the context to the Publish and Subscribe functions. This ensures that the functions have the necessary context for proper execution. The bug in the examples/publish/main.go file is fixed by adding the context package and passing the context to the Publish function. Previously, the Publish function was called without a context, which could lead to unexpected behavior. The bug in the examples/subscribe/main.go file is fixed in a similar manner. The context package is imported, and the context is passed to the Subscribe function. This ensures that the Subscribe function has the necessary context for proper execution. These changes ensure that the subscription and publishing functionalities work correctly in the examples. Signed-off-by: SammyOina <sammyoina@gmail.com>
rodneyosodo
suggested changes
Oct 12, 2023
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Signed-off-by: SammyOina <sammyoina@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do?
Creates Modbus adapter on mainflux edge
Which issue(s) does this PR fix/relate to?
https://github.com/ultravioletrs/issues/issues/278
List any changes that modify/break current functionality
Have you included tests for your changes?
Did you document any new/modified functionality?
Notes
To test using a simulated device,
See readme for examples