feat(storage): support bucket restore in soft delete phase 2 #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mahendra-google
requested review from
gurusai-voleti,
harsha-accenture,
shubhangi-google and
thiyaguk09
gurusai-voleti
approved these changes
Nov 28, 2024
shubhangi-google
approved these changes
Nov 28, 2024
mahendra-google
force-pushed
the
restore_bucket_soft_delete_phase_2
branch
from
cb1650a to
db71efc
Compare
thiyaguk09
reviewed
Jan 28, 2025
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/RestoreBucketTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/ListBucketsTest.cs
Outdated
Show resolved
Hide resolved
thiyaguk09
approved these changes
Jan 28, 2025
Collaborator
thiyaguk09
left a comment
thiyaguk09
left a comment
There was a problem hiding this comment.
LGTM, @shubhangi-google Approved, Further Review Requested
PiperOrigin-RevId: 720741557 Source-Link: googleapis/googleapis@280725e Source-Link: googleapis/googleapis-gen@194c4c3 Copy-Tag: eyJwIjoiYXBpcy9Hb29nbGUuTWFwcy5QbGFjZXMuVjEvLk93bEJvdC55YW1sIiwiaCI6IjE5NGM0YzMyOTQxZmU1NTlkZDFhOTg0OGY0ODkxZGI1OTU1NjJhZjUifQ==
…ly.github.com> Co-authored-by: Amanda Tarafa Mas <14878252+amanda-tarafa@users.noreply.github.com> modified: generator-input/apis.json
…val of package version override
mahendra-google
force-pushed
the
restore_bucket_soft_delete_phase_2
branch
from
0957b16 to
7efe472
Compare
Co-authored-by: Amanda Tarafa Mas <14878252+amanda-tarafa@users.noreply.github.com>
…BucketOptionsTest.cs Co-authored-by: Amanda Tarafa Mas <14878252+amanda-tarafa@users.noreply.github.com>
…Options.cs Co-authored-by: Amanda Tarafa Mas <14878252+amanda-tarafa@users.noreply.github.com>
…tBucketsOptionsTest.cs Co-authored-by: Amanda Tarafa Mas <14878252+amanda-tarafa@users.noreply.github.com>
Owner
Author
|
@amrik-mahal Internal PR is ready for re-review. |
…onTests/ListBucketsTest.cs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature request includes the following:-
Includes
Rebase PR on upstream/main (same as origin/main here ) with squashed reviewed commits till now